Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agents platform and new CLI #104

Merged
merged 39 commits into from
Apr 11, 2019
Merged

Agents platform and new CLI #104

merged 39 commits into from
Apr 11, 2019

Conversation

gdiazlo
Copy link
Contributor

@gdiazlo gdiazlo commented Apr 10, 2019

Refactor agents and cli. It is not 100% ready, but it is getting too big. So I propose to merge now, and continue the work.

gdiazlo added 30 commits April 10, 2019 14:41
@gdiazlo
Refactor of agents: new snapshot sore client, task manager, and agent…
eb4da9b 
… api
@gdiazlo
Redesign gossip package to refine the API
8a610d9
@gdiazlo
Redesign cli flag parsing. Use new library to generate options from c…
40d10bb 
…onfig objects
@gdiazlo
Update scripts to launch qed components
6ec665d
@gdiazlo
Objects with start / stop should not block
58844f9
@gdiazlo
Include sender into the server package.
8729a04
@gdiazlo
Server start() does not block. Use stop() to shutitdown
066b569
@gdiazlo
Change internal server error by bad request errors.
4810039
@gdiazlo
Remove metadata from BatchSnapshots as it is now in gossip.Message
542d9f0
@gdiazlo
Comment old testing code until it is refactored with the new gossip api
940a34b
@gdiazlo
Add documentation to config options for the cli
59df917
@gdiazlo
Remove old files
8c11b0a
@gdiazlo
Mark event as required option for qed client add subcommand
2a256fd
@gdiazlo
Add publisher agent
d6a8b68
@gdiazlo
Move test service to tests folder
dfc0417
@gdiazlo
Update startup scripts to support new cli options
2a5a133
@gdiazlo
MOve test_service to notifierstore in testutils
e86fec6
@gdiazlo
Update start scripts with new options
d36dc3d
@gdiazlo
Add default configurations for simple implementations of notifier, st…
42a152f 
…ore and taskmanager
@gdiazlo
Update comments
9161b1f
@gdiazlo
Add error to message bus publish api
397d95d
@gdiazlo
Check for tasks errors in batchProcessor
cf1b2a0
@gdiazlo
REmove old test_service e2e implementation
4f3ad48
@gdiazlo
Increase batch size to 500, as the qed log performance has increased.
d63a6c1
@gdiazlo
remove old agents code
db80337
@gdiazlo
Fix version checking in balloon consistency query
e3c511b
@gdiazlo
Fix default endpoint in client config
5a400d2
@gdiazlo
Configure QED client for monitor agent needs
e3ca384
@gdiazlo
Remove unneeded debug messages
b004e3c
@gdiazlo
Add var to allow cflags usage in go runs inside the script
f973299
@gdiazlo gdiazlo requested review from iknite, jllucas and aalda April 10, 2019 12:45
@suizman
Copy link
Contributor

suizman commented Apr 10, 2019 •
edited
Loading

To prevent unnecessary crashes,before merging we should migrate all the test and deploy scripts/code to use the new flags scheme.

aalda
aalda reviewed Apr 11, 2019
View reviewed changes
Copy link
Contributor

@aalda aalda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmd/agent_auditor.go
log.Infof("Auditor is unable to get membership proof from QED server: %v", err)

switch fmt.Sprintf("%T", err) {
case "*errors.errorString":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you checking this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To check whether the membership API is working properly or not. Is of little value probably, just monitoring it is available and working.

@gdiazlo gdiazlo merged commit 57d474b into BBVA:master Apr 11, 2019
suizman pushed a commit to jllucas/qed that referenced this pull request Jun 4, 2019
@gdiazlo
Merge pull request BBVA#104 from gdiazlo/agents_platform
f2e214a 
Agents platform and new CLI

Former-commit-id: 57d474b
suizman pushed a commit that referenced this pull request Sep 30, 2019
@gdiazlo
Merge pull request #104 from gdiazlo/agents_platform
b0f98a8 
Agents platform and new CLI

Former-commit-id: b136052 [formerly 57d474b]
Former-commit-id: f2e214a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalda aalda aalda left review comments

@iknite iknite Awaiting requested review from iknite

@jllucas jllucas Awaiting requested review from jllucas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gdiazlo @suizman @aalda @panchoh