Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics #102

Merged
merged 7 commits into from
Apr 5, 2019
Merged

Metrics #102

merged 7 commits into from
Apr 5, 2019

Conversation

aalda
Copy link
Contributor

@aalda aalda commented Apr 5, 2019

Includes complete raft wal metrics.
Moves adds and membership queries from balloon to raftballoon.

@aalda aalda requested a review from jllucas April 5, 2019 18:07
@aalda
Copy link
Contributor Author

aalda commented Apr 5, 2019

@jllucas note that some metrics definitions have changed in the dashboard definition.

@aalda aalda assigned gdiazlo and unassigned gdiazlo Apr 5, 2019
@aalda aalda requested a review from gdiazlo April 5, 2019 18:09
jllucas
jllucas approved these changes Apr 5, 2019
View reviewed changes
Copy link

@jllucas jllucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gdiazlo
gdiazlo approved these changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@gdiazlo gdiazlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aalda aalda merged commit fd426ab into BBVA:master Apr 5, 2019
@aalda aalda deleted the metrics branch April 8, 2019 07:51
suizman pushed a commit to jllucas/qed that referenced this pull request Jun 4, 2019
@aalda
Merge pull request BBVA#102 from aalda/metrics
363ed33 
Metrics

Former-commit-id: fd426ab
suizman pushed a commit that referenced this pull request Sep 30, 2019
@aalda
Merge pull request #102 from aalda/metrics
6d2232e 
Metrics

Former-commit-id: 39a594d [formerly fd426ab]
Former-commit-id: 363ed33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jllucas jllucas jllucas approved these changes

@gdiazlo gdiazlo gdiazlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aalda @gdiazlo @jllucas