auditor: Type Switching error to discent between connection errors an…

…d tampering
BBVA · Mar 6, 2019 · ea92130 · ea92130
1 parent a7b9e9d
commit ea92130
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/gossip/auditor/auditor.go b/gossip/auditor/auditor.go
@@ -178,9 +178,16 @@ type MembershipTask struct {
 func (t MembershipTask) Do() {
 	proof, err := t.qed.MembershipDigest(t.s.Snapshot.EventDigest, t.s.Snapshot.Version)
 	if err != nil {
-		// retry
-		metrics.QedAuditorGetMembershipProofErrTotal.Inc()
+		// TODO: retry
 		log.Infof("Unable to get membership proof from QED server: %s", err.Error())
+
+		switch fmt.Sprintf("%T", err) {
+		case "*errors.errorString":
+			t.sendAlert(fmt.Sprintf("Unable to get membership proof from QED server: %s", err.Error()))
+		default:
+			metrics.QedAuditorGetMembershipProofErrTotal.Inc()
+		}
+
 		return
 	}
 

diff --git a/tests/e2e/agents_test.go b/tests/e2e/agents_test.go
@@ -132,7 +132,7 @@ func TestAgents(t *testing.T) {
 			time.Sleep(1 * time.Second)
 			alerts, err := getAlert()
 			assert.NoError(t, err)
-			assert.True(t, strings.Contains(string(alerts), "Unable to verify snapshot"), "Must exist auditor alerts")
+			assert.True(t, strings.Contains(string(alerts), "Unable to get membership proof"), "Must exist auditor alerts")
 		})
 
 		let("Check Monitor does not create any alert", func(t *testing.T) {