fix: AWS deploy: monitor.go: don't flood storage with alerts when err…

…or in getting proofs Co-authored-by: Jose Luis Lucas <[email protected]>
BBVA · Mar 6, 2019 · bc21782 · bc21782
1 parent eed61d2
commit bc21782
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/gossip/metrics/metrics.go b/gossip/metrics/metrics.go
@@ -96,6 +96,13 @@ var (
 		},
 	)
 
+	QedMonitorGetIncrementalProofErrTotal = prometheus.NewCounter(
+		prometheus.CounterOpts{
+			Name: "qed_monitor_get_incremental_proof_err_total",
+			Help: "Number of errors trying to get incremental proofs by monitors.",
+		},
+	)
+
 	metricsList = []prometheus.Collector{
 		QedAuditorInstancesCount,
 		QedMonitorInstancesCount,
@@ -110,6 +117,7 @@ var (
 		QedPublisherBatchesProcessSeconds,
 
 		QedAuditorGetMembershipProofErrTotal,
+		QedMonitorGetIncrementalProofErrTotal,
 	}
 )
 

diff --git a/gossip/monitor/monitor.go b/gossip/monitor/monitor.go
@@ -199,8 +199,8 @@ func (m Monitor) executeTask(task QueryTask) {
 	resp, err := m.client.Incremental(task.Start, task.End)
 	if err != nil {
 		// TODO: retry
-		m.sendAlert(fmt.Sprintf("Unable to verify incremental proof from %d to %d", task.Start, task.End))
-		log.Infof("Unable to verify incremental proof from %d to %d", task.Start, task.End)
+		metrics.QedMonitorGetIncrementalProofErrTotal.Inc()
+		log.Infof("Unable to get incremental proof from QED server: %s", err.Error())
 		return
 	}
 	ok := m.client.VerifyIncremental(resp, &task.StartSnapshot, &task.EndSnapshot, hashing.NewSha256Hasher())