Skip to content

Commit

Permalink
Fix rocksdb include path for CXXFLAGS
Browse files Browse the repository at this point in the history
  • Loading branch information
aalda committed Mar 25, 2019
1 parent 1da0db6 commit 6cae8c3
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 13 deletions.
4 changes: 0 additions & 4 deletions rocksdb/extended.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -126,10 +126,6 @@ uint64_t rocksdb_histogram_get_sum(rocksdb_histogram_data_t* data) {
return data->rep->sum;
}

double rocksdb_histogram_get_min(rocksdb_histogram_data_t* data) {
return data->rep->min;
}

void rocksdb_histogram_data_destroy(rocksdb_histogram_data_t* data);

void rocksdb_histogram_data_destroy(rocksdb_histogram_data_t* data) {
Expand Down
2 changes: 0 additions & 2 deletions rocksdb/extended.h
Original file line number Diff line number Diff line change
Expand Up @@ -507,8 +507,6 @@ extern uint64_t rocksdb_histogram_get_count(rocksdb_histogram_data_t* data);

extern uint64_t rocksdb_histogram_get_sum(rocksdb_histogram_data_t* data);

extern double rocksdb_histogram_get_min(rocksdb_histogram_data_t* data);

extern void rocksdb_histogram_data_destroy(rocksdb_histogram_data_t* data);

#ifdef __cplusplus
Expand Down
2 changes: 1 addition & 1 deletion rocksdb/flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
package rocksdb

// #cgo CFLAGS: -I${SRCDIR}/../c-deps/rocksdb/include
// #cgo CXXFLAGS: -std=c++11 -O3 -I${SRCDIR}
// #cgo CXXFLAGS: -std=c++11 -O3 -I${SRCDIR}/../c-deps/rocksdb/include
// #cgo LDFLAGS: -L${SRCDIR}/../c-deps/libs
// #cgo LDFLAGS: -lrocksdb
// #cgo LDFLAGS: -ljemalloc
Expand Down
5 changes: 0 additions & 5 deletions rocksdb/histogram.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,6 @@ func (d *HistogramData) GetSum() uint64 {
return uint64(C.rocksdb_histogram_get_sum(d.c))
}

// GetMin returns the min value.
func (d *HistogramData) GetMin() float64 {
return float64(C.rocksdb_histogram_get_min(d.c))
}

// Destroy deallocates the HistogramData object.
func (d *HistogramData) Destroy() {
C.rocksdb_histogram_data_destroy(d.c)
Expand Down
1 change: 0 additions & 1 deletion rocksdb/statistics_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ func TestGetHistogramData(t *testing.T) {
require.True(t, histogramData.GetMax() > 0)
require.True(t, histogramData.GetCount() > 0)
require.True(t, histogramData.GetSum() > 0)
require.True(t, histogramData.GetMin() > 0)
}

func TestReset(t *testing.T) {
Expand Down

0 comments on commit 6cae8c3

Please sign in to comment.