Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/route: read command from parameter, file or stdin #46

Closed
panchoh opened this issue Oct 22, 2019 · 3 comments
Closed

cmd/route: read command from parameter, file or stdin #46

panchoh opened this issue Oct 22, 2019 · 3 comments
Assignees
@CesarGallego
Labels
bug Something isn't working
Milestone
0.3.0

Comments

@panchoh
Copy link
Contributor

panchoh commented Oct 22, 2019

kapow/internal/cmd/route.go

Line 43 in be6a2ef

// TODO: Read command from parameter, file or stdin

@panchoh panchoh added this to the 1.0.0 milestone Oct 22, 2019
@panchoh
Copy link
Contributor Author

panchoh commented Oct 23, 2019 •
edited
Loading

Recap:

  1. -c + string
  2. file.pow
  3. '-'
  4. null command

@panchoh panchoh added the bug Something isn't working label Oct 23, 2019
@panchoh panchoh mentioned this issue Oct 23, 2019
Closed
@CesarGallego
Copy link
Contributor

The file to read must be a entry point "compilant" file, not a pow file. Right?

@CesarGallego CesarGallego self-assigned this Oct 23, 2019
@panchoh
Copy link
Contributor Author

panchoh commented Oct 23, 2019 •
edited
Loading

The file to read must be a entry point "compilant" file, not a pow file. Right?

Yes, AFAIK. That's the only thing that makes sense to me.

@CesarGallego CesarGallego mentioned this issue Oct 23, 2019
Open
panchoh added a commit that referenced this issue Oct 23, 2019
@panchoh
Drop TODO line of solved issue
7674725 
Related to #46
panchoh added a commit that referenced this issue Oct 23, 2019
@panchoh
Leverage ioutil.ReadAll() and ioutil.ReadFile() to simplify logic
ae3bd76 
Related to: #46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CesarGallego CesarGallego

Labels
bug Something isn't working
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
2 participants
@panchoh @CesarGallego