This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Hover gap below media indicator #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenisHdz
approved these changes
Jun 28, 2019
ghost
approved these changes
Jun 28, 2019
pjlee11
approved these changes
Jun 28, 2019
|
Media indicator looks good on IE11 and IE10. |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #620
Overall change: Fixes gap below media indicator
Code changes:
Testing:
npm run ci:packages && npm run buildcp -r ../psammead/packages/components/psammead-media-indicator/dist/ ./node_modules/@bbc/psammead-media-indicator/distnpm run build && npm starthttp://localhost:7080/igbo