Storybook version update and other dependencies #594
Conversation
j-pendlebury
added
ws-home
|
@DenisBBC I didn't bump the version of Psammead, which means no need for CHANGELOG update. Unless I need to bump version of Psammead as well? 🤔 |
|
@DenisBBC done now 😄 |
There was a problem hiding this comment.
There are a bunch of other storybook updates available, e.g. #603 Suggest they are all done at once.
j-pendlebury
changed the title
Co-Authored-By: Drew McMillan <[email protected]>
There was a problem hiding this comment.
This introduces a warning in the console in storybook:
The pseudo class ":first-child" is potentially unsafe when doing server-side rendering. Try changing it to ":first-of-type".
But this is due to a known issue in storybook: storybookjs/storybook#6998 and I don't think blocks this going forward :)
Otherwise lgtm but needs code owner approval
| viewBox={`${svgs[svgName].viewbox.width} ${ | ||
| svgs[svgName].viewbox.height | ||
| }`} | ||
| viewBox={`${svgs[svgName].viewbox.width} ${svgs[svgName].viewbox.height}`} |
|
After updating versions of all the dependencies in this PR, the inputProvider doesn't update values for different stories, e.g.
Will raise a new PR to update to version 5.1.4 of Storybook, which includes some |
Resolves N/A
Overall change:
Use version 5.1.3 of Storybook. This is version contains a fix for a bug when viewing components in a new tab canvas. More info here: storybookjs/storybook#6800
Updated:
Tests added for new features