Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Add GREY_8 colour #4609

Merged
merged 5 commits into from
Jan 6, 2022
Merged

Add GREY_8 colour #4609

merged 5 commits into from
Jan 6, 2022

Conversation

DarioR01
Copy link
Contributor

@DarioR01 DarioR01 commented Jan 6, 2022 •
edited
Loading

Resolves #NUMBER

Overall change: Adding #202224 as C_Grey_8 for Editorial onward journey component: horizontally scrollable promos

Code changes:

  • A bullet point list of key code changes that have been made.
  • When describing code changes, try to communicate how and why you implemented something a specific way, not just what has changed.
  • (BBC contributors only) This PR follows the repository use guidelines
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

Dario Russo added 2 commits January 6, 2022 10:50
@DarioR01 DarioR01 changed the title new Grey scale colour GREY_8 Add GREY_8 colour Jan 6, 2022
@DarioR01 DarioR01 self-assigned this Jan 6, 2022
Dario Russo and others added 2 commits January 6, 2022 11:32
@DarioR01 DarioR01 mentioned this pull request Jan 6, 2022
Merged
7 tasks
@DarioR01 DarioR01 merged commit beaaf67 into latest Jan 6, 2022
@DarioR01 DarioR01 deleted the new-colour branch January 6, 2022 12:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicola-d-bbc nicola-d-bbc nicola-d-bbc approved these changes

@amoore108 amoore108 amoore108 approved these changes

Assignees

@DarioR01 DarioR01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DarioR01 @amoore108 @nicola-d-bbc