Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

fix a11y comma bug in psammead-navigation #4590

Merged
merged 3 commits into from
Nov 2, 2021
Merged

fix a11y comma bug in psammead-navigation #4590

merged 3 commits into from
Nov 2, 2021

Conversation

DarioR01
Copy link
Contributor

@DarioR01 DarioR01 commented Nov 1, 2021 •
edited
Loading

Resolves #9561

Concatenated comma to the text.

Code changes:

  • As Above
  • (BBC contributors only) This PR follows the repository use guidelines
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

Dario Russo added 2 commits November 1, 2021 12:15
@DarioR01 DarioR01 self-assigned this Nov 1, 2021
@DarioR01 DarioR01 added a11y Accessibility-related task bug Something isn't working labels Nov 1, 2021
@DarioR01 DarioR01 changed the title snapshots fix a11y spans and comma bug in psammead CurrentLink Nov 1, 2021
@DarioR01 DarioR01 changed the title fix a11y spans and comma bug in psammead CurrentLink fix a11y spans and comma bug in psammead-navigation Nov 1, 2021
MuhammadAHussain
MuhammadAHussain approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@MuhammadAHussain MuhammadAHussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@DarioR01 DarioR01 changed the title fix a11y spans and comma bug in psammead-navigation fix a11y comma bug in psammead-navigation Nov 1, 2021
@DarioR01
Copy link
Contributor Author

DarioR01 commented Nov 1, 2021

Works on Talkback
Test link: https://5d28eb5ee163f6002046d6fb-kokqnwbbod.chromatic.com/?path=/story/components-navigation-canonical--igbo

@greenc05
Copy link
Contributor

greenc05 commented Nov 1, 2021

Thanks @DarioR01 Please confirm it is as expected will all our supported screen readers.

@DarioR01
Copy link
Contributor Author

DarioR01 commented Nov 1, 2021

Checked with no CSS and shows content as intended

@DarioR01
Copy link
Contributor Author

DarioR01 commented Nov 1, 2021 •
edited
Loading

Test Link: https://5d28eb5ee163f6002046d6fb-kokqnwbbod.chromatic.com/?path=/story/components-navigation-canonical--igbo
Need test on:

  • JAWS
  • TalkBack Dario
  • NVDA Dario
  • VoiceOver MAC Dario
  • VoiceOver iPhone Pedram

@pvaliani pvaliani self-requested a review November 1, 2021 14:52
pvaliani
pvaliani approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@pvaliani pvaliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working on iPhone Vo

@paruchurisilpa
Copy link
Contributor

Test Link: https://5d28eb5ee163f6002046d6fb-kokqnwbbod.chromatic.com/?path=/story/components-navigation-canonical--igbo

  • JAWS

Checked JAWS and works as expected..

@DarioR01 DarioR01 merged commit 3b5849e into latest Nov 2, 2021
@joshcoventry joshcoventry deleted the fix-comma-CurrentLink branch January 12, 2022 10:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pvaliani pvaliani pvaliani approved these changes

@nicola-d-bbc nicola-d-bbc nicola-d-bbc approved these changes

@MuhammadAHussain MuhammadAHussain MuhammadAHussain approved these changes

Assignees

@DarioR01 DarioR01

Labels
a11y Accessibility-related task bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve Talkback reading comma in a range of components in Simorgh and Psammead
6 participants
@DarioR01 @greenc05 @paruchurisilpa @MuhammadAHussain @nicola-d-bbc @pvaliani