Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Adds Noto Serif Sinhala Font #4548

Merged
merged 28 commits into from
Sep 16, 2021
Merged

Adds Noto Serif Sinhala Font #4548

merged 28 commits into from
Sep 16, 2021

Conversation

HarveyPeachey
Copy link
Contributor

@HarveyPeachey HarveyPeachey commented Sep 6, 2021 •
edited
Loading

Resolves bbc/simorgh#9365

Overall change:
Adds Noto Serif Sinhala font and adds typography script with new sizes and line height

Code changes:

  • Adds Noto Serif Sinhala font
  • Adds Typography script font sizes and line heights for new font
  • Bumps psammead-styles and gel-foundations versions
  • (BBC contributors only) This PR follows the repository use guidelines
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@HarveyPeachey HarveyPeachey added the cross-team For visibility for both World Service teams (Engage & Media) label Sep 6, 2021
@HarveyPeachey HarveyPeachey self-assigned this Sep 6, 2021
@github-actions
Copy link

github-actions bot commented Sep 6, 2021

Checkout your storybook preview here http://psammead-preview.tools.bbc.co.uk/4548

@HarveyPeachey HarveyPeachey changed the title Add font noto serif sinhala Replace Iskoola with Noto Serif Sinhala Font Sep 7, 2021
@HarveyPeachey HarveyPeachey marked this pull request as ready for review September 7, 2021 15:07
@HarveyPeachey HarveyPeachey changed the title Replace Iskoola with Noto Serif Sinhala Font Adds Noto Serif Sinhala Font Sep 10, 2021
@andrewscfc
Copy link
Contributor

Would you be able to check the UI tests to make sure the fonts look okay, unsure what to expect for this one: https://www.chromatic.com/test?appId=5d28eb5ee163f6002046d6fb&id=614224309fd82f003a8044fa

DarioR01
DarioR01 approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@DarioR01 DarioR01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked all the values, looks great to me

@HarveyPeachey HarveyPeachey changed the title Adds Noto Serif Sinhala Font [DNM] Adds Noto Serif Sinhala Font Sep 16, 2021
@HarveyPeachey HarveyPeachey changed the title [DNM] Adds Noto Serif Sinhala Font Adds Noto Serif Sinhala Font Sep 16, 2021
@HarveyPeachey HarveyPeachey merged commit 994eb86 into latest Sep 16, 2021
@HarveyPeachey HarveyPeachey deleted the add-font-noto-serif-sinhala branch September 16, 2021 17:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JonBeeb JonBeeb JonBeeb left review comments

@DarioR01 DarioR01 DarioR01 approved these changes

@andrewscfc andrewscfc andrewscfc approved these changes

Assignees

@HarveyPeachey HarveyPeachey

@nicola-d-bbc nicola-d-bbc

@pvaliani pvaliani

Labels
cross-team For visibility for both World Service teams (Engage & Media)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update fonts on the Sinhala service
6 participants
@HarveyPeachey @andrewscfc @JonBeeb @DarioR01 @nicola-d-bbc @pvaliani