Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Adds bottom nav border in high contrast mode #4475

Merged
merged 6 commits into from
May 10, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
"@bbc/psammead-media-indicator": "6.1.0",
"@bbc/psammead-media-player": "5.1.0",
"@bbc/psammead-most-read": "6.0.29",
"@bbc/psammead-navigation": "9.1.1",
"@bbc/psammead-navigation": "9.2.0",
"@bbc/psammead-paragraph": "4.0.16",
"@bbc/psammead-play-button": "3.0.20",
"@bbc/psammead-radio-schedule": "5.1.32",
Expand Down
1 change: 1 addition & 0 deletions packages/components/psammead-navigation/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<!-- prettier-ignore -->
| Version | Description |
|---------|-------------|
| 9.2.0 | [PR#4475](https://github.com/bbc/psammead/pull/4475) Adds bottom nav border in high contrast mode |
| 9.1.1 | [PR#4438](https://github.com/bbc/psammead/pull/4438) add data-e2e attribute for e2e tests |
| 9.1.0 | [PR#4437](https://github.com/bbc/psammead/pull/4437) add data-e2e attribute for e2e tests |
| 9.0.11 | [PR#4420](https://github.com/bbc/psammead/pull/4420) bumps 3rd-party dependencies |
Expand Down
2 changes: 1 addition & 1 deletion packages/components/psammead-navigation/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@bbc/psammead-navigation",
"version": "9.1.1",
"version": "9.2.0",
"description": "A navigation bar to use on index pages",
"main": "dist/index.js",
"module": "esm/index.js",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,15 @@ exports[`Navigation should render correctly 1`] = `
border-top: 0.0625rem solid #FFFFFF;
}

.emotion-0::after {
content: '';
position: absolute;
bottom: 0;
right: 0;
left: 0;
border-bottom: 0.0625rem solid transparent;
}

.emotion-0 .emotion-7::after {
left: 0;
}
Expand Down Expand Up @@ -277,6 +286,15 @@ exports[`Navigation should render correctly when ampOpenClass prop is provided 1
}
}

.emotion-0::after {
content: '';
position: absolute;
bottom: 0;
right: 0;
left: 0;
border-bottom: 0.0625rem solid transparent;
}

.emotion-0 .emotion-7::after {
left: 0;
}
Expand Down Expand Up @@ -541,6 +559,15 @@ exports[`Navigation should render correctly when isOpen is true 1`] = `
border-top: 0.0625rem solid #FFFFFF;
}

.emotion-0::after {
content: '';
position: absolute;
bottom: 0;
right: 0;
left: 0;
border-bottom: 0.0625rem solid transparent;
}

.emotion-0 .emotion-7::after {
left: 0;
}
Expand Down Expand Up @@ -844,6 +871,15 @@ exports[`Scrollable Navigation should render correctly 1`] = `
border-top: 0.0625rem solid #FFFFFF;
}

.emotion-2::after {
content: '';
position: absolute;
bottom: 0;
right: 0;
left: 0;
border-bottom: 0.0625rem solid transparent;
}

.emotion-2 .emotion-9::after {
left: 0;
}
Expand Down
9 changes: 9 additions & 0 deletions packages/components/psammead-navigation/src/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,15 @@ const StyledNav = styled.nav`
`}
border-top: 0.0625rem solid ${C_WHITE};

&::after {
content: '';
position: absolute;
bottom: 0;
right: 0;
left: 0;
border-bottom: 0.0625rem solid transparent;
}

${StyledListItem} {
${({ dir }) => `
&::after {
Expand Down