This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Mega packages bumps #4420
Merged
Mega packages bumps #4420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checkout your storybook preview here http://psammead-preview.tools.bbc.co.uk/4420 |
added 2 commits
March 4, 2021 14:49
Bump package versions for psammead, psammead-amp-geo, psammead-brand, psammead-bulleted-list, psammead-bulletin, psammead-byline, psammead-caption, psammead-consent-banner, psammead-content-anchor, psammead-copyright, psammead-embed-error, psammead-episode-list, psammead-figure, psammead-grid, psammead-heading-index, psammead-headings, psammead-image-placeholder, psammead-image, psammead-inline-link, psammead-live-label, psammead-media-indicator, psammead-media-player, psammead-most-read, psammead-navigation, psammead-oembed, psammead-paragraph, psammead-play-button, psammead-podcast-promo, psammead-radio-schedule, psammead-script-link, psammead-section-label, psammead-sitewide-links, psammead-social-embed, psammead-story-promo-list, psammead-story-promo, psammead-timestamp, psammead-topic-tags, psammead-useful-links, psammead-visually-hidden-text, psammead-timestamp-container, moment-timezone-include, psammead-assets, psammead-calendars, psammead-detokeniser, psammead-locales, psammead-rich-text-transforms, psammead-storybook-helpers, psammead-styles, psammead-test-helpers, web-vitals,
Updates changelogs for psammead, psammead-amp-geo, psammead-brand, psammead-bulleted-list, psammead-bulletin, psammead-byline, psammead-caption, psammead-consent-banner, psammead-content-anchor, psammead-copyright, psammead-embed-error, psammead-episode-list, psammead-figure, psammead-grid, psammead-heading-index, psammead-headings, psammead-image-placeholder, psammead-image, psammead-inline-link, psammead-live-label, psammead-media-indicator, psammead-media-player, psammead-most-read, psammead-navigation, psammead-oembed, psammead-paragraph, psammead-play-button, psammead-podcast-promo, psammead-radio-schedule, psammead-script-link, psammead-section-label, psammead-sitewide-links, psammead-social-embed, psammead-story-promo-list, psammead-story-promo, psammead-timestamp, psammead-topic-tags, psammead-useful-links, psammead-visually-hidden-text, psammead-timestamp-container, moment-timezone-include, psammead-assets, psammead-calendars, psammead-detokeniser, psammead-locales, psammead-rich-text-transforms, psammead-storybook-helpers, psammead-styles, psammead-test-helpers, web-vitals
jroebu14
added
the
cross-team
andrewscfc
reviewed
Mar 5, 2021
| "@bbc/psammead-styles": "^7.2.2" | ||
| "@bbc/psammead-styles": "^7.2.2", | ||
| "@emotion/styled": "^11.0.0", | ||
| "react": "^17.0.1" |
There was a problem hiding this comment.
how do these dev dependencies work with the peer dependencies here? I guess the peer dependencies declare that you can integrate and use this package with a project (Simorgh in our case) that uses Emotion styled > 11 and react > 16.9 ? Should we change the react one to be react 17? I imagine this will be needed across all packages
There was a problem hiding this comment.
I think if we do then we introduce a backwards-incompatible breaking change because consumers who haven't upgraded to React v17 won't be able to use new versions of Psammead components.
chris-hinds
approved these changes
Mar 5, 2021
HarveyPeachey
approved these changes
Mar 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall change:
Upgrades a lot of packages.
Updates all minor and patch dependencies and the following major dependencies:
Consists of several Renovate PRs:
Also adds a new dependency
many-pkgthat runs checks onpostinstallto flag problems with ourpackage.jsonfiles. Running this check onpostinstallwas inspired by Chakra UI's approach.Running
many-pkghighlighted some problems such as dependency mismatches across packages and peerDeps not being installed in devDeps. These issues were fixed in this PR.Code changes:
Adds new root dependency
many-pkgand 2 new scripts:check:pkgs- run this to validate ourpackage.jsonfiles using these checks. Runs onpostinstallfix:pkgs- run this to auto-fix problems highlighted by runningcheck:pkgsmkdirpv1 breaking changesUsed in moment-timezone-include package
What changed?
More details - https://www.npmjs.com/package/mkdirp/v/1.0.0#use-this-module-mkdirp-1x-if
Changes needed
None. We didn't use callbacks - are using mkdirp.sync and we use a supported version of Node.
object-hashv2 breaking changesUsed in moment-timezone-include package
What changed?
More details - https://github.com/puleos/object-hash#v200
Changes needed
None.
eslint-config-prettierv8 breaking changesUsed in root package
What changed?
More details
Changes needed
None.
@testing-library/react-hooksv5 breaking changesUsed in root package
What changed?
suppressErrorsremovedMore details
Changes needed
None.