This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Media Indicator - Pass dir #3109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sareh
reviewed
Feb 11, 2020
| <> | ||
| <MediaIndicator | ||
| type="audio" | ||
| script={script} | ||
| service={service} | ||
| dir={dir} | ||
| isInline={boolean('inline?', true)} | ||
| /> | ||
| <StyledHeadline script={script} service={service} promoHasImage={false}> |
There was a problem hiding this comment.
Could you please also update the text 'example text' to use the localised text from Storybook helpers? It'd particularly be useful when looking at RTL services. https://github.com/bbc/psammead/blob/4f6e4e9f621d3c917cfbeeb7b7727468b703f608/packages/components/psammead-media-indicator/src/index.stories.jsx#L116
OlgaLyubin
reviewed
Feb 11, 2020
packages/components/psammead-media-indicator/src/__snapshots__/index.test.jsx.snap
Outdated
Show resolved
Hide resolved
OlgaLyubin
reviewed
Feb 11, 2020
sareh
approved these changes
Feb 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #NUMBER
Overall change:
Pass direction to the Media Indicator to apply the right padding.
Code changes:
dirprop to theMediaIndicatorcomponentBefore:
After:
