This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
BBC Scotland SVG #2192
Merged
BBC Scotland SVG #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sareh
requested review from
jamesbhobbs,
dr3,
j-pendlebury and
jroebu14
as code owners
dr3
reviewed
Sep 19, 2019
sareh
commented
Sep 19, 2019
dr3
approved these changes
Sep 19, 2019
RayNjeri
approved these changes
Sep 20, 2019
|
Confirmed with Jim - this PR is good to be merged. It'll be fully UX reviewed when integrated into Simorgh. |
This was referenced Sep 20, 2019
|
Was this checked in high contrast mode and also changing the colour preferences in FF @sareh? I assume that we also have some visually hidden text for it? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No ticket
Storybook link: http://localhost:8180/?path=/story/utilities-svgs--scotland
Overall change: Add Scotland SVG needed for banner on
/scotland/articles/*Code changes: