Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Update utility package READMEs #212

Merged
merged 16 commits into from
Dec 18, 2018
Merged

Update utility package READMEs #212

merged 16 commits into from
Dec 18, 2018
+69 −35

Conversation

bcmn
Copy link
Contributor

@bcmn bcmn commented Dec 14, 2018

Resolves #77

Updates utility package READMEs, mainly to update descriptions, also to add some more detailed examples. Still need to bump changelogs.

  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@bcmn bcmn self-assigned this Dec 14, 2018
@sareh sareh added the alpha-2 label Dec 17, 2018
@bcmn
Copy link
Contributor Author

bcmn commented Dec 18, 2018

Blocked on #221, as it merges two of these packages.

@bcmn bcmn added blocked This issue should not be worked on until another internal issue is completed - see desc for details and removed blocked This issue should not be worked on until another internal issue is completed - see desc for details labels Dec 18, 2018
@bcmn
Copy link
Contributor Author

bcmn commented Dec 18, 2018

Unblocked. Will fix conflicts.

dr3
dr3 suggested changes Dec 18, 2018
View reviewed changes
packages/utilities/gel-foundations/README.md Outdated Show resolved Hide resolved
packages/utilities/gel-foundations/README.md Outdated Show resolved Hide resolved
packages/utilities/gel-foundations/package.json Outdated Show resolved Hide resolved
packages/utilities/psammead-styles/README.md Show resolved Hide resolved
packages/utilities/psammead-styles/package.json Outdated Show resolved Hide resolved
dr3
dr3 approved these changes Dec 18, 2018
View reviewed changes
Copy link
Contributor

@dr3 dr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bcmn bcmn merged commit b040c5d into latest Dec 18, 2018
@bcmn bcmn deleted the improve-utility-descriptions branch December 18, 2018 13:00
@thekp thekp mentioned this pull request Jul 12, 2019
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dr3 dr3 dr3 approved these changes

@ChrisBAshton ChrisBAshton ChrisBAshton approved these changes

Assignees

@bcmn bcmn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bcmn @ChrisBAshton @dr3 @sareh