Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Create media indicator component #436

Closed
1 task done
j-pendlebury opened this issue Apr 9, 2019 · 1 comment · Fixed by #448
Closed
1 task done

Create media indicator component #436

j-pendlebury opened this issue Apr 9, 2019 · 1 comment · Fixed by #448
Assignees
@dr3
Labels
ws-home Tasks for the WS Home Team
Milestone
Story Promo (WS FP)

Comments

@j-pendlebury
Copy link
Contributor

j-pendlebury commented Apr 9, 2019 •
edited by dr3
Loading

Is your feature request related to a problem? Please describe.
Our card design includes a play icon to indicate the promo is of a page with a video

Describe the solution you'd like
Create a video promo component for use on our card component. If provided a duration, it should render it, however if its not provided the video promo should be square, centered on the play icon.

Please work with UX to get the iconography and typography required for this work.

Accessibility, does this need hidden text? Work with @greenc05 to decide this

Consider right to left. the play icon should remain the lrt direction, the text might however be on the opposite side. Research/Ask a RTL reader

This should be a psammead component package

UX designs - [LINK]

Design of the video promo
image

Design of it inside a card
image

Testing notes
[Tester to complete]

Dev insight: Snapshot and storybook should be sufficient
@dr3
Copy link
Contributor

dr3 commented Apr 10, 2019

Blocking https://github.com/bbc/simorgh/issues/1552

@dr3 dr3 changed the title Create a card component - mobile width + video promo Create a card component - video promo Apr 10, 2019
@dr3 dr3 changed the title Create a card component - video promo Create card video promo component Apr 10, 2019
@jamesdonoh jamesdonoh transferred this issue from bbc/simorgh Apr 10, 2019
@dr3 dr3 added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-home Tasks for the WS Home Team labels Apr 10, 2019
@dr3 dr3 removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Apr 11, 2019
@dr3 dr3 self-assigned this Apr 15, 2019
This was referenced Apr 16, 2019
Closed
Merged
@dr3 dr3 changed the title Create card video promo component Create media indicator component Apr 17, 2019
@dr3 dr3 closed this as completed in #448 Apr 25, 2019
@amywalkerdev amywalkerdev added this to the Story Promo (WS FP) milestone May 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dr3 dr3

Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Milestone
Story Promo (WS FP)
Development

Successfully merging a pull request may close this issue.

Add media indicator BBC-archive/psammead
Add media indicator BBC-archive/psammead
3 participants
@dr3 @j-pendlebury @amywalkerdev