Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Create a card component - mobile width #435

Closed
1 task done
j-pendlebury opened this issue Apr 9, 2019 · 3 comments · Fixed by #488
Closed
1 task done

Create a card component - mobile width #435

j-pendlebury opened this issue Apr 9, 2019 · 3 comments · Fixed by #488
Assignees
@j-pendlebury
Labels
investigation ws-home Tasks for the WS Home Team
Milestone
Story Promo (WS FP)

Comments

@j-pendlebury
Copy link
Contributor

j-pendlebury commented Apr 9, 2019 •
edited by dr3
Loading

Is your feature request related to a problem? Please describe.
Following #391 which adds the card component with support focus on 600px we should iterate on it to support mobile widths

Describe the solution you'd like
Update the homepage card component to work at mobile widths.

UX designs - [LINK] (DONT TRUST THIS SCREENSHOT, ITS OLD, CHECK ZEPLIN)

image
image

Testing notes
Dev insight: Unit test snapshots and storybook should be sufficient

Additional context
A 600px component to be created in #391.
@dr3
Copy link
Contributor

dr3 commented Apr 10, 2019

Blocked on #391

@jamesdonoh jamesdonoh transferred this issue from bbc/simorgh Apr 10, 2019
@dr3 dr3 added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-home Tasks for the WS Home Team labels Apr 10, 2019
@dr3 dr3 removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Apr 11, 2019
@dr3
Copy link
Contributor

dr3 commented Apr 29, 2019 •
edited
Loading

Investigate that this is currently implemented :) if not, create a PR to fix it

@j-pendlebury j-pendlebury self-assigned this Apr 30, 2019
@j-pendlebury
Copy link
Contributor Author

j-pendlebury commented Apr 30, 2019 •
edited
Loading

On mobile widths, the story introduction should not be displayed. Will open a PR to make this change.

image

@j-pendlebury j-pendlebury mentioned this issue May 1, 2019
Merged
2 tasks
@amywalkerdev amywalkerdev added this to the Story Promo (WS FP) milestone May 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@j-pendlebury j-pendlebury

Labels
investigation ws-home Tasks for the WS Home Team
Projects
None yet
Milestone
Story Promo (WS FP)
Development

Successfully merging a pull request may close this issue.

Story Promo - mobile widths BBC-archive/psammead
3 participants
@dr3 @j-pendlebury @amywalkerdev