Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Commit

Permalink
Merge pull request #3611 from bbc/add-dark-mode-image-placeholder
Browse files Browse the repository at this point in the history
Implementing 'dark mode' for psammead-image-placeholder
  • Loading branch information
RichardPK authored Jul 20, 2020
2 parents 357092c + 11f6bfc commit c8bc945
Show file tree
Hide file tree
Showing 8 changed files with 46 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<!-- prettier-ignore -->
| Version | Description |
|---------|-------------|
| 1.2.4 | [PR#3611](https://github.com/bbc/psammead/pull/3611) Make placeholder darkmode compatible |
| 1.2.37 | [PR#3613](https://github.com/bbc/psammead/pull/3613) Talos - Bump Dependencies - @bbc/psammead-assets |
| 1.2.36 | [PR#3467](https://github.com/bbc/psammead/pull/3467) Talos - Bump Dependencies - @bbc/psammead-styles |
| 1.2.35 | [PR#3397](https://github.com/bbc/psammead/pull/3397) Talos - Bump Dependencies - @bbc/psammead-styles |
Expand Down
1 change: 1 addition & 0 deletions packages/components/psammead-image-placeholder/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ The `psammead-image-placeholder` component is a `div` with a base-64 encoded SVG
| Argument | Type | Required | Default | Example |
| -------- | -------------------------------------- | -------- | ------- | ------- |
| Ratio | Number, ratio between height and width | Yes | N/A | 65.625 |
| darkMode | Bool, true (dark) or false (normal) | No | false | false |

## Usage

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@bbc/psammead-image-placeholder",
"version": "1.2.37",
"version": "1.2.4",
"main": "dist/index.js",
"module": "esm/index.js",
"sideEffects": false,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,24 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`ImagePlaceholder should render dark mode version correctly 1`] = `
.c0 {
position: relative;
height: 0;
overflow: hidden;
background-color: #3F3F42;
background-position: center center;
background-repeat: no-repeat;
background-size: 30%;
padding-bottom: 56.25%;
width: 100%;
background-image: url(data:image/svg+xml;base64,<svg xmlns="http://www.w3.org/2000/svg" width="78" height="23" viewBox="0 0 78 23">
    <g fill="#6E6E73" fill-rule="evenodd">
        <path d="M53.066 21.807H76.08V.15H53.066v21.658zm14.5-18.645l-.311-.05-.125-.018c-.176-.024-.355-.045-.535-.062-.122-.011-.245-.02-.367-.027-.218-.014-.433-.02-.64-.02-.095 0-.149.002-.242.004-.173.003-.343.011-.51.021-.095.006-.189.015-.281.023-.138.012-.273.027-.406.044l-.111.015-.124.018-.153.024-.197.035c-.09.016-.18.034-.269.053-.546.115-1.051.269-1.517.45-.24.095-.472.196-.692.303-.182.09-.359.183-.527.28-.165.095-.322.19-.474.292-.086.058-.173.117-.255.177-.072.051-.143.103-.212.156-.146.113-.287.228-.418.344-.124.11-.244.22-.355.331-.096.096-.193.194-.284.296-.092.103-.184.207-.272.316-.096.118-.19.239-.28.364-.066.093-.131.187-.194.283-.042.065-.084.13-.125.197-.24.392-.45.813-.623 1.26-.215.56-.372 1.16-.457 1.8-.026.201-.048.406-.06.615-.009.16-.015.323-.015.487 0 .124.001.246.009.366.008.126.018.25.032.374l.01.086c.018.147.041.29.069.433l.033.166c.026.118.053.235.084.35.04.149.083.295.131.438.06.176.123.348.193.515.11.265.232.519.363.758.077.141.156.278.239.41.065.105.133.206.2.304.09.13.184.256.276.375.098.126.198.244.296.356.123.141.246.27.365.389l.065.063c.1.096.207.198.33.303.084.071.17.147.266.221.088.069.179.14.277.21.116.084.237.169.368.252.137.088.281.177.435.262.304.17.64.334 1.008.482.138.056.281.108.429.159.146.05.296.097.451.141.265.077.544.144.837.2.235.046.48.084.733.115.252.03.512.053.783.067.13.006.264.012.4.014l.186.002c.484 0 .932-.018 1.347-.053l.081-.007c.166-.015.325-.032.48-.051.237-.03.463-.065.678-.103.136-.024.267-.05.395-.078.199-.043.387-.089.567-.136.132-.036.26-.073.384-.11.147-.044.29-.092.426-.138l.13-.046c.066-.023.155-.055.26-.096.138-.054.305-.12.495-.202.114-.048.237-.103.363-.16.112-.052.23-.11.35-.167.05-.025.1-.048.15-.074V14.61c-.033.022-.07.043-.105.064l-.202.122c-.202.122-.396.238-.592.344-.215.116-.424.224-.632.322-.366.172-.715.317-1.054.439-.644.23-1.235.378-1.756.47l-.183.029c-.145.023-.282.04-.414.054-.207.023-.397.035-.57.043-.112.005-.217.007-.313.007-.21 0-.426-.005-.645-.021-.257-.019-.519-.047-.783-.092-.427-.071-.856-.18-1.275-.332-.063-.022-.125-.047-.186-.071-.04-.016-.082-.033-.12-.05-.07-.03-.137-.059-.205-.091-.144-.068-.288-.142-.428-.22-.069-.04-.137-.08-.208-.126-.07-.044-.14-.09-.21-.137-.085-.06-.17-.122-.254-.187-.08-.063-.163-.131-.232-.19l-.097-.089-.049-.044-.029-.028-.036-.034c-.132-.132-.254-.265-.364-.398-.063-.075-.12-.15-.177-.226-.053-.073-.103-.146-.151-.22-.046-.068-.089-.139-.13-.207-.06-.104-.116-.21-.167-.312-.044-.088-.084-.177-.12-.264-.064-.148-.119-.299-.164-.44-.036-.112-.066-.223-.092-.329-.078-.308-.119-.59-.14-.83-.01-.092-.015-.178-.019-.257-.005-.118-.007-.22-.007-.302 0-.054 0-.116.003-.187.007-.17.02-.384.056-.627.021-.148.052-.307.09-.473.027-.11.058-.222.093-.338.033-.105.071-.21.112-.32.027-.072.059-.145.09-.219.044-.1.092-.2.144-.301.039-.077.082-.152.126-.228.098-.169.208-.336.333-.501.044-.06.09-.12.14-.178.062-.076.128-.154.197-.227l.106-.113c.541-.541 1.15-.946 1.78-1.233.098-.045.198-.085.297-.124.101-.04.199-.076.301-.11.109-.037.22-.07.33-.101.103-.03.208-.055.31-.079.105-.024.21-.044.313-.063.114-.022.229-.039.341-.054.114-.015.227-.027.34-.036.215-.02.427-.029.632-.029.07 0 .138 0 .206.002.153.003.302.008.448.018.101.007.2.013.298.022.186.018.366.04.536.066.152.023.299.05.436.077.213.042.406.089.58.134.113.03.217.061.312.09.143.042.265.08.36.113.164.056.254.09.254.09.146.051.288.108.427.164.188.076.367.157.54.234.142.065.278.132.405.194.106.052.204.104.297.151.161.084.298.16.41.22l.301.164v-2.9s-.181-.075-.493-.193c-.139-.052-.302-.114-.487-.18-.103-.035-.211-.075-.327-.114-.092-.03-.186-.064-.285-.096-.11-.035-.225-.073-.343-.109l-.262-.078-.079-.022c-.086-.025-.173-.05-.262-.073l-.32-.083-.21-.05c-.114-.026-.23-.051-.348-.075-.12-.025-.241-.048-.363-.07zM35.377 12.092v4.257h2.764l.146-.005c.093-.003.224-.008.384-.022.301-.028.695-.083 1.078-.212.348-.118.685-.293.943-.55.1-.1.182-.204.248-.308.217-.342.271-.689.283-.886.007-.085.006-.135.006-.135s.002-.038 0-.104c-.003-.082-.013-.241-.057-.412-.051-.202-.149-.436-.322-.65-.033-.041-.069-.082-.107-.12-.077-.077-.158-.15-.248-.216-.152-.111-.324-.206-.512-.288-.248-.107-.527-.188-.832-.245-.156-.03-.322-.053-.491-.07-.105-.01-.21-.016-.319-.023-.094-.006-.194-.01-.291-.01h-2.673M35.377 5.621v4.035h1.339s.089 0 .207-.003c.092-.003.202-.01.3-.014.276-.021.657-.06 1.038-.166.074-.02.15-.044.222-.07.299-.106.585-.262.808-.48.177-.175.294-.368.371-.557.095-.23.128-.452.142-.608.012-.14.011-.229.011-.229s.003-.066-.002-.17c-.01-.177-.046-.463-.185-.738-.067-.132-.158-.258-.283-.381-.15-.149-.333-.263-.529-.35-.377-.166-.808-.232-1.17-.256-.159-.01-.303-.013-.425-.013h-1.844z" transform="translate(.5 .496)"/>
        <path d="M26.546 21.807h23.015V.15H26.546v21.658zm6.038-18.622v15.6h5.871s2.864.078 4.445-1.503c1.287-1.287 1.194-2.776 1.194-2.776s.093-1.554-1.098-2.746c-1.016-1.015-2.312-1.286-2.312-1.286s.586-.274 1.036-.724c.21-.211.96-.888.96-2.531 0-1.656-1.102-2.608-1.102-2.608s-1.207-1.426-3.932-1.426h-5.062zM8.858 12.092v4.257h2.764l.145-.005c.094-.003.225-.008.385-.022.3-.028.695-.083 1.078-.212.347-.118.685-.293.943-.55.1-.1.181-.204.248-.308.217-.342.271-.689.283-.886.006-.085.006-.135.006-.135v-.104c-.003-.082-.013-.241-.057-.412-.052-.202-.149-.436-.323-.65-.033-.041-.068-.082-.107-.12-.076-.077-.157-.15-.248-.216-.151-.111-.324-.206-.512-.288-.248-.107-.526-.188-.831-.245-.156-.03-.322-.053-.492-.07-.104-.01-.209-.016-.318-.023-.094-.006-.194-.01-.292-.01H8.858M8.858 5.621v4.035h1.338s.09 0 .208-.003c.092-.003.202-.01.3-.014.276-.021.657-.06 1.038-.166.074-.02.149-.044.222-.07.299-.106.585-.262.808-.48.177-.175.294-.368.37-.557.096-.23.129-.452.143-.608.012-.14.011-.229.011-.229s.003-.066-.002-.17c-.01-.177-.046-.463-.185-.738-.067-.132-.158-.258-.283-.381-.15-.149-.333-.263-.53-.35-.376-.166-.807-.232-1.17-.256-.158-.01-.302-.013-.425-.013H8.858z" transform="translate(.5 .496)"/>
        <path d="M.027 21.807h23.015V.15H.027v21.658zM6.064 3.185v15.6h5.872s2.864.078 4.445-1.503c1.287-1.287 1.194-2.776 1.194-2.776s.093-1.554-1.098-2.746c-1.016-1.015-2.312-1.286-2.312-1.286s.586-.274 1.035-.724c.21-.211.96-.888.96-2.531 0-1.656-1.102-2.608-1.102-2.608s-1.206-1.426-3.93-1.426H6.063z" transform="translate(.5 .496)"/>
    </g>
</svg>
);
}
<div
class="c0"
/>
`;

exports[`ImagePlaceholder should render landscape images correctly 1`] = `
.c0 {
position: relative;
Expand Down
20 changes: 14 additions & 6 deletions packages/components/psammead-image-placeholder/src/index.jsx
Original file line number Diff line number Diff line change
@@ -1,24 +1,32 @@
import styled from 'styled-components';
import { number } from 'prop-types';
import { C_CHALK } from '@bbc/psammead-styles/colours';
import { BBC_BLOCKS } from '@bbc/psammead-assets/svgs';
import { number, bool } from 'prop-types';
import { C_CHALK, C_SHADOW } from '@bbc/psammead-styles/colours';
import { BBC_BLOCKS, BBC_BLOCKS_DARK_MODE } from '@bbc/psammead-assets/svgs';

const bgImageDark = `url(data:image/svg+xml;base64,${BBC_BLOCKS_DARK_MODE})`;
const bgImageRegular = `url(data:image/svg+xml;base64,${BBC_BLOCKS})`;

const ImagePlaceholder = styled.div`
position: relative;
height: 0;
overflow: hidden;
background-color: ${C_CHALK};
background-color: ${({ darkMode }) => (darkMode ? C_SHADOW : C_CHALK)};
background-position: center center;
background-repeat: no-repeat;
background-size: 30%;
padding-bottom: ${props => props.ratio}%;
width: 100%;
/* placeholder BBC blocks SVG */
background-image: url(data:image/svg+xml;base64,${BBC_BLOCKS});
background-image: ${({ darkMode }) =>
darkMode ? bgImageDark : bgImageRegular};
`;

ImagePlaceholder.propTypes = {
ratio: number.isRequired,
darkMode: bool,
};

ImagePlaceholder.defaultProps = {
darkMode: false,
};

export default ImagePlaceholder;
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,9 @@ storiesOf('Components|Images/ImagePlaceholder', module)
'9x16 image placeholder',
() => <ImagePlaceholder ratio={portraitImageRatio} />,
{ notes },
)
.add(
'16x9 dark mode image placeholder',
() => <ImagePlaceholder ratio={landscapeImageRatio} darkMode />,
{ notes },
);
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,8 @@ describe('ImagePlaceholder', () => {
'should render square images correctly',
<ImagePlaceholder ratio={squareImageRatio} />,
);
shouldMatchSnapshot(
'should render dark mode version correctly',
<ImagePlaceholder ratio={landscapeImageRatio} darkMode />,
);
});

0 comments on commit c8bc945

Please sign in to comment.