This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Add media indicator #448
Merged
Add media indicator #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr3
requested review from
jamesbhobbs,
chris-hinds,
jamesdonoh,
j-pendlebury,
pjlee11 and
sareh
as code owners
|
This is ready for review, but its not quite vertically centred, if anyone has any ideas how to do this without some css hack with line height, i'm all ears :P |
j-pendlebury
suggested changes
Apr 18, 2019
Co-Authored-By: dr3 <[email protected]>
andrew-nowak
suggested changes
Apr 18, 2019
packages/components/psammead-media-indicator/src/__snapshots__/index.test.jsx.snap
Outdated
Show resolved
Hide resolved
DenisHdz
reviewed
Apr 23, 2019
andrew-nowak
approved these changes
Apr 24, 2019
|
LGTM. Happy for this to be merged. |
j-pendlebury
approved these changes
Apr 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #436
Overall change: Creates a media indicator component
Code changes: