Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default_factory for OPV #141

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Use default_factory for OPV #141

merged 1 commit into from
Sep 22, 2022

Conversation

cmungall
Copy link
Contributor

@cmungall cmungall commented Sep 21, 2022

Addresses #140 but this likely needs done in other places

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Please include the syntax that is relevant (Fixes, Closes, Implements, Issue ). Only use Issue if this pull request doesn't resolve the entire issue

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit tests
  • Integration tests
  • Test coverage >= 90%
  • Flake8 Tests
  • Mypy Tests
  • Other -

Test Configuration

  • Python Version:

PR Self Evaluation

strikethrough things that don’t make sense for your PR

  • My code follows the agreed upon best practices
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests or modified existing tests that prove my fix is effective or that my feature works
  • Existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in the appropriate modules
  • I have performed a self-review of my own code

Addresses BASIN-3D#140 but this likely needs done in other places
@cmungall
Copy link
Contributor Author

sorry, I was too lazy to add a unit test!

@vchendrix vchendrix changed the base branch from main to develop September 22, 2022 17:01
Copy link
Contributor

@vchendrix vchendrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pointer @cmungall ! We appreciate your attention to this.

@vchendrix vchendrix merged commit aa4f6fd into BASIN-3D:develop Sep 22, 2022
@vchendrix
Copy link
Contributor

sorry, I was too lazy to add a unit test!

No worries @cmungall. We will be more formally addressing this anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants