Skip to content

Commit

Permalink
update change_log (Azure#23742)
Browse files Browse the repository at this point in the history
* update change_log

* Update change_log.py

* Update tools/azure-sdk-tools/packaging_tools/change_log.py

* Update tools/azure-sdk-tools/packaging_tools/change_log.py

Co-authored-by: Yuchao Yan <[email protected]>
  • Loading branch information
Wzb123456789 and msyyc authored Mar 30, 2022
1 parent 8fdb885 commit 51c5ade
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions tools/azure-sdk-tools/packaging_tools/change_log.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def operation(self, diff_entry):
return

# Is this a new operation, inside a known operation group?
function_name, *remaining_path = remaining_path
function_name, parameter_name, *remaining_path = remaining_path
if not remaining_path:
if is_deletion:
self.breaking_changes.append(_REMOVE_OPERATION.format(operation_name, function_name))
Expand All @@ -80,7 +80,7 @@ def operation(self, diff_entry):
return

# So method signaure changed. Be vague for now
self.breaking_changes.append(_SIGNATURE_CHANGE.format(operation_name, function_name))
self.breaking_changes.append(_SIGNATURE_CHANGE.format(operation_name, function_name, parameter_name))

def models(self, diff_entry):
path, is_deletion = self._unpack_diff_entry(diff_entry)
Expand Down Expand Up @@ -144,7 +144,7 @@ def models(self, diff_entry):
## Breaking Changes
_REMOVE_OPERATION_GROUP = "Removed operation group {}"
_REMOVE_OPERATION = "Removed operation {}.{}"
_SIGNATURE_CHANGE = "Operation {}.{} has a new signature"
_SIGNATURE_CHANGE = "Operation {}.{} has a new signature {}"
_MODEL_SIGNATURE_CHANGE = "Model {} has a new signature"
_MODEL_PARAM_DELETE = "Model {} no longer has parameter {}"
_MODEL_PARAM_ADD_REQUIRED = "Model {} has a new required parameter {}"
Expand Down

0 comments on commit 51c5ade

Please sign in to comment.