Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR @azure/arm-app] Use the common-types for ApiVersionParameter #8377

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions common/config/rush/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

33 changes: 33 additions & 0 deletions sdk/app/arm-app/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,38 @@
# Release History

## 1.0.0 (2022-03-31)

**Features**

- Added operation group Namespaces
- Added operation ContainerApps.beginUpdate
- Added operation ContainerApps.beginUpdateAndWait
- Added operation ManagedEnvironments.beginUpdate
- Added operation ManagedEnvironments.beginUpdateAndWait
- Added Interface CheckNameAvailabilityRequest
- Added Interface CheckNameAvailabilityResponse
- Added Interface NamespacesCheckNameAvailabilityOptionalParams
- Added Type Alias CheckNameAvailabilityReason
- Added Type Alias NamespacesCheckNameAvailabilityResponse
- Interface ContainerAppsRevisionsListRevisionsNextOptionalParams has a new optional parameter filter
- Interface ContainerAppsRevisionsListRevisionsOptionalParams has a new optional parameter filter
- Interface ContainerAppsUpdateOptionalParams has a new optional parameter resumeFrom
- Interface ContainerAppsUpdateOptionalParams has a new optional parameter updateIntervalInMs
- Interface GithubActionConfiguration has a new optional parameter contextPath
- Interface GithubActionConfiguration has a new optional parameter image
- Interface ManagedEnvironmentsUpdateOptionalParams has a new optional parameter resumeFrom
- Interface ManagedEnvironmentsUpdateOptionalParams has a new optional parameter updateIntervalInMs
- Interface TrafficWeight has a new optional parameter label
- Class ContainerAppsAPIClient has a new parameter namespaces
- Added Enum KnownCheckNameAvailabilityReason

**Breaking Changes**

- Removed operation ContainerApps.update
- Removed operation ManagedEnvironments.update
- Interface GithubActionConfiguration no longer has parameter dockerfilePath


## 1.0.0-beta.1 (2022-03-23)

The package of @azure/arm-app is using our next generation design principles. To learn more, please refer to our documentation [Quick Start](https://aka.ms/js-track2-quickstart).
13 changes: 1 addition & 12 deletions sdk/app/arm-app/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ This package contains an isomorphic SDK (runs both in Node.js and in browsers) f

[Source code](https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/app/arm-app) |
[Package (NPM)](https://www.npmjs.com/package/@azure/arm-app) |
[API reference documentation](https://docs.microsoft.com/javascript/api/@azure/arm-app?view=azure-node-preview) |
[API reference documentation](https://docs.microsoft.com/javascript/api/@azure/arm-app) |
[Samples](https://github.com/Azure-Samples/azure-samples-js-management)

## Getting started
Expand All @@ -16,8 +16,6 @@ This package contains an isomorphic SDK (runs both in Node.js and in browsers) f
- [LTS versions of Node.js](https://nodejs.org/about/releases/)
- Latest versions of Safari, Chrome, Edge and Firefox.

See our [support policy](https://github.com/Azure/azure-sdk-for-js/blob/main/SUPPORT.md) for more details.

### Prerequisites

- An [Azure subscription][azure_sub].
Expand Down Expand Up @@ -51,17 +49,8 @@ For more information about how to create an Azure AD Application check out [this
```javascript
const { ContainerAppsAPIClient } = require("@azure/arm-app");
const { DefaultAzureCredential } = require("@azure/identity");
// For client-side applications running in the browser, use InteractiveBrowserCredential instead of DefaultAzureCredential. See https://aka.ms/azsdk/js/identity/examples for more details.

const subscriptionId = "00000000-0000-0000-0000-000000000000";
const client = new ContainerAppsAPIClient(new DefaultAzureCredential(), subscriptionId);

// For client-side applications running in the browser, use this code instead:
// const credential = new InteractiveBrowserCredential({
// tenantId: "<YOUR_TENANT_ID>",
// clientId: "<YOUR_CLIENT_ID>"
// });
// const client = new ContainerAppsAPIClient(credential, subscriptionId);
```


Expand Down
8 changes: 4 additions & 4 deletions sdk/app/arm-app/_meta.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"commit": "82fdf284eea880a8e027c354911a814999a77178",
"commit": "67dced7e1cc2411f29a24dafd40f367bdf1e4ba1",
"readme": "specification/app/resource-manager/readme.md",
"autorest_command": "autorest --version=3.7.3 --typescript --modelerfour.lenient-model-deduplication --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=D:\\work\\azure-sdk-for-js ..\\azure-rest-api-specs\\specification\\app\\resource-manager\\readme.md --use=@autorest/[email protected]beta.17 --generate-sample=true",
"autorest_command": "autorest --version=3.7.3 --typescript --modelerfour.lenient-model-deduplication --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-js ../azure-rest-api-specs/specification/app/resource-manager/readme.md --use=@autorest/[email protected]alpha.16.20220105.1",
"repository_url": "https://github.com/Azure/azure-rest-api-specs.git",
"release_tool": "@azure-tools/js-sdk-release-tools@2.1.3",
"use": "@autorest/[email protected]beta.17"
"release_tool": "@azure-tools/js-sdk-release-tools@2.2.1",
"use": "@autorest/[email protected]alpha.16.20220105.1"
}
32 changes: 8 additions & 24 deletions sdk/app/arm-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"sdk-type": "mgmt",
"author": "Microsoft Corporation",
"description": "A generated SDK for ContainerAppsAPIClient.",
"version": "1.0.0-beta.1",
"version": "1.0.0",
"engines": {
"node": ">=12.0.0"
},
Expand All @@ -29,13 +29,13 @@
"types": "./types/arm-app.d.ts",
"devDependencies": {
"@microsoft/api-extractor": "^7.18.11",
"@rollup/plugin-commonjs": "^21.0.1",
"@rollup/plugin-json": "^4.1.0",
"@rollup/plugin-multi-entry": "^4.1.0",
"@rollup/plugin-node-resolve": "^13.1.3",
"@rollup/plugin-commonjs": "11.0.2",
"@rollup/plugin-json": "^4.0.0",
"@rollup/plugin-multi-entry": "^3.0.0",
"@rollup/plugin-node-resolve": "^8.0.0",
"mkdirp": "^1.0.4",
"rollup": "^2.66.1",
"rollup-plugin-sourcemaps": "^0.6.3",
"rollup": "^1.16.3",
"rollup-plugin-sourcemaps": "^0.4.2",
"typescript": "~4.2.0",
"uglify-js": "^3.4.9",
"rimraf": "^3.0.0",
Expand Down Expand Up @@ -98,21 +98,5 @@
"docs": "echo skipped"
},
"sideEffects": false,
"//metadata": {
"constantPaths": [
{
"path": "src/containerAppsAPIClient.ts",
"prefix": "packageDetails"
}
]
},
"autoPublish": true,
"//sampleConfiguration": {
"productName": "",
"productSlugs": [
"azure"
],
"disableDocsMs": true,
"apiRefLink": "https://docs.microsoft.com/javascript/api/@azure/arm-app?view=azure-node-preview"
}
"autoPublish": true
}

This file was deleted.

74 changes: 51 additions & 23 deletions sdk/app/arm-app/review/arm-app.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,22 @@ export interface CertificatesUpdateOptionalParams extends coreClient.OperationOp
// @public
export type CertificatesUpdateResponse = Certificate;

// @public
export type CheckNameAvailabilityReason = string;

// @public
export interface CheckNameAvailabilityRequest {
name?: string;
type?: string;
}

// @public
export interface CheckNameAvailabilityResponse {
message?: string;
nameAvailable?: boolean;
reason?: CheckNameAvailabilityReason;
}

// @public
export interface ClientRegistration {
clientId?: string;
Expand Down Expand Up @@ -274,13 +290,6 @@ export interface ContainerAppCollection {
value: ContainerApp[];
}

// @public
export interface ContainerAppPatch {
tags?: {
[propertyName: string]: string;
};
}

// @public
export interface ContainerAppProbe {
failureThreshold?: number;
Expand Down Expand Up @@ -324,12 +333,13 @@ export interface ContainerApps {
beginCreateOrUpdateAndWait(resourceGroupName: string, name: string, containerAppEnvelope: ContainerApp, options?: ContainerAppsCreateOrUpdateOptionalParams): Promise<ContainerAppsCreateOrUpdateResponse>;
beginDelete(resourceGroupName: string, name: string, options?: ContainerAppsDeleteOptionalParams): Promise<PollerLike<PollOperationState<void>, void>>;
beginDeleteAndWait(resourceGroupName: string, name: string, options?: ContainerAppsDeleteOptionalParams): Promise<void>;
beginUpdate(resourceGroupName: string, name: string, containerAppEnvelope: ContainerApp, options?: ContainerAppsUpdateOptionalParams): Promise<PollerLike<PollOperationState<void>, void>>;
beginUpdateAndWait(resourceGroupName: string, name: string, containerAppEnvelope: ContainerApp, options?: ContainerAppsUpdateOptionalParams): Promise<void>;
get(resourceGroupName: string, name: string, options?: ContainerAppsGetOptionalParams): Promise<ContainerAppsGetResponse>;
listByResourceGroup(resourceGroupName: string, options?: ContainerAppsListByResourceGroupOptionalParams): PagedAsyncIterableIterator<ContainerApp>;
listBySubscription(options?: ContainerAppsListBySubscriptionOptionalParams): PagedAsyncIterableIterator<ContainerApp>;
listCustomHostNameAnalysis(resourceGroupName: string, containerAppName: string, options?: ContainerAppsListCustomHostNameAnalysisOptionalParams): Promise<ContainerAppsListCustomHostNameAnalysisResponse>;
listSecrets(resourceGroupName: string, name: string, options?: ContainerAppsListSecretsOptionalParams): Promise<ContainerAppsListSecretsResponse>;
update(resourceGroupName: string, name: string, containerAppEnvelope: ContainerAppPatch, options?: ContainerAppsUpdateOptionalParams): Promise<ContainerAppsUpdateResponse>;
}

// @public (undocumented)
Expand Down Expand Up @@ -358,6 +368,8 @@ export class ContainerAppsAPIClient extends coreClient.ServiceClient {
// (undocumented)
managedEnvironmentsStorages: ManagedEnvironmentsStorages;
// (undocumented)
namespaces: Namespaces;
// (undocumented)
operations: Operations;
// (undocumented)
subscriptionId: string;
Expand Down Expand Up @@ -527,13 +539,15 @@ export type ContainerAppsRevisionsGetRevisionResponse = Revision;

// @public
export interface ContainerAppsRevisionsListRevisionsNextOptionalParams extends coreClient.OperationOptions {
filter?: string;
}

// @public
export type ContainerAppsRevisionsListRevisionsNextResponse = RevisionCollection;

// @public
export interface ContainerAppsRevisionsListRevisionsOptionalParams extends coreClient.OperationOptions {
filter?: string;
}

// @public
Expand Down Expand Up @@ -591,11 +605,10 @@ export type ContainerAppsSourceControlsListByContainerAppResponse = SourceContro

// @public
export interface ContainerAppsUpdateOptionalParams extends coreClient.OperationOptions {
resumeFrom?: string;
updateIntervalInMs?: number;
}

// @public
export type ContainerAppsUpdateResponse = ContainerApp;

// @public
export interface ContainerResources {
cpu?: number;
Expand Down Expand Up @@ -793,7 +806,8 @@ export interface GitHub {
// @public
export interface GithubActionConfiguration {
azureCredentials?: AzureCredentials;
dockerfilePath?: string;
contextPath?: string;
image?: string;
os?: string;
publishType?: string;
registryInfo?: RegistryInfo;
Expand Down Expand Up @@ -916,6 +930,14 @@ export enum KnownCertificateProvisioningState {
Succeeded = "Succeeded"
}

// @public
export enum KnownCheckNameAvailabilityReason {
// (undocumented)
AlreadyExists = "AlreadyExists",
// (undocumented)
Invalid = "Invalid"
}

// @public
export enum KnownContainerAppProvisioningState {
// (undocumented)
Expand Down Expand Up @@ -1076,23 +1098,17 @@ export type ManagedEnvironment = TrackedResource & {
appLogsConfiguration?: AppLogsConfiguration;
};

// @public
export interface ManagedEnvironmentPatch {
tags?: {
[propertyName: string]: string;
};
}

// @public
export interface ManagedEnvironments {
beginCreateOrUpdate(resourceGroupName: string, name: string, environmentEnvelope: ManagedEnvironment, options?: ManagedEnvironmentsCreateOrUpdateOptionalParams): Promise<PollerLike<PollOperationState<ManagedEnvironmentsCreateOrUpdateResponse>, ManagedEnvironmentsCreateOrUpdateResponse>>;
beginCreateOrUpdateAndWait(resourceGroupName: string, name: string, environmentEnvelope: ManagedEnvironment, options?: ManagedEnvironmentsCreateOrUpdateOptionalParams): Promise<ManagedEnvironmentsCreateOrUpdateResponse>;
beginDelete(resourceGroupName: string, name: string, options?: ManagedEnvironmentsDeleteOptionalParams): Promise<PollerLike<PollOperationState<void>, void>>;
beginDeleteAndWait(resourceGroupName: string, name: string, options?: ManagedEnvironmentsDeleteOptionalParams): Promise<void>;
beginUpdate(resourceGroupName: string, name: string, environmentEnvelope: ManagedEnvironment, options?: ManagedEnvironmentsUpdateOptionalParams): Promise<PollerLike<PollOperationState<void>, void>>;
beginUpdateAndWait(resourceGroupName: string, name: string, environmentEnvelope: ManagedEnvironment, options?: ManagedEnvironmentsUpdateOptionalParams): Promise<void>;
get(resourceGroupName: string, name: string, options?: ManagedEnvironmentsGetOptionalParams): Promise<ManagedEnvironmentsGetResponse>;
listByResourceGroup(resourceGroupName: string, options?: ManagedEnvironmentsListByResourceGroupOptionalParams): PagedAsyncIterableIterator<ManagedEnvironment>;
listBySubscription(options?: ManagedEnvironmentsListBySubscriptionOptionalParams): PagedAsyncIterableIterator<ManagedEnvironment>;
update(resourceGroupName: string, name: string, environmentEnvelope: ManagedEnvironmentPatch, options?: ManagedEnvironmentsUpdateOptionalParams): Promise<ManagedEnvironmentsUpdateResponse>;
}

// @public
Expand Down Expand Up @@ -1201,11 +1217,10 @@ export interface ManagedEnvironmentStoragesCollection {

// @public
export interface ManagedEnvironmentsUpdateOptionalParams extends coreClient.OperationOptions {
resumeFrom?: string;
updateIntervalInMs?: number;
}

// @public
export type ManagedEnvironmentsUpdateResponse = ManagedEnvironment;

// @public
export interface ManagedServiceIdentity {
readonly principalId?: string;
Expand All @@ -1219,6 +1234,18 @@ export interface ManagedServiceIdentity {
// @public
export type ManagedServiceIdentityType = string;

// @public
export interface Namespaces {
checkNameAvailability(resourceGroupName: string, managedEnvironmentName: string, checkNameAvailabilityRequest: CheckNameAvailabilityRequest, options?: NamespacesCheckNameAvailabilityOptionalParams): Promise<NamespacesCheckNameAvailabilityResponse>;
}

// @public
export interface NamespacesCheckNameAvailabilityOptionalParams extends coreClient.OperationOptions {
}

// @public
export type NamespacesCheckNameAvailabilityResponse = CheckNameAvailabilityResponse;

// @public
export interface Nonce {
nonceExpirationInterval?: string;
Expand Down Expand Up @@ -1445,6 +1472,7 @@ export type TrackedResource = Resource & {

// @public
export interface TrafficWeight {
label?: string;
latestRevision?: boolean;
revisionName?: string;
weight?: number;
Expand Down
Loading