Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR azure-resourcemanager-kusto] Propagate the comment to the event-grid provider too #13184

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sdk/kusto/azure-resourcemanager-kusto/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# Release History

## 1.0.0-beta.5 (Unreleased)
## 1.0.0-beta.1 (2022-03-09)

- Azure Resource Manager Kusto client library for Java. This package contains Microsoft Azure SDK for Kusto Management SDK. The Azure Kusto management API provides a RESTful set of web services that interact with Azure Kusto services to manage your clusters and databases. The API enables you to create, update, and delete clusters and databases. Package tag package-2022-02. For documentation on how to use this package, please see [Azure Management Libraries for Java](https://aka.ms/azsdk/java/mgmt).

### Features Added

Expand Down
2 changes: 1 addition & 1 deletion sdk/kusto/azure-resourcemanager-kusto/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Various documentation is available to help you get started
<dependency>
<groupId>com.azure.resourcemanager</groupId>
<artifactId>azure-resourcemanager-kusto</artifactId>
<version>1.0.0-beta.4</version>
<version>1.0.0-beta.5</version>
</dependency>
```
[//]: # ({x-version-update-end})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ public static Configurable configure() {

/** The Configurable allowing configurations to be set. */
public static final class Configurable {
private final ClientLogger logger = new ClientLogger(Configurable.class);
private static final ClientLogger LOGGER = new ClientLogger(Configurable.class);

private HttpClient httpClient;
private HttpLogOptions httpLogOptions;
Expand Down Expand Up @@ -200,9 +200,11 @@ public Configurable withRetryPolicy(RetryPolicy retryPolicy) {
* @return the configurable object itself.
*/
public Configurable withDefaultPollInterval(Duration defaultPollInterval) {
this.defaultPollInterval = Objects.requireNonNull(defaultPollInterval, "'retryPolicy' cannot be null.");
this.defaultPollInterval =
Objects.requireNonNull(defaultPollInterval, "'defaultPollInterval' cannot be null.");
if (this.defaultPollInterval.isNegative()) {
throw logger.logExceptionAsError(new IllegalArgumentException("'httpPipeline' cannot be negative"));
throw LOGGER
.logExceptionAsError(new IllegalArgumentException("'defaultPollInterval' cannot be negative"));
}
return this;
}
Expand All @@ -224,7 +226,7 @@ public KustoManager authenticate(TokenCredential credential, AzureProfile profil
.append("-")
.append("com.azure.resourcemanager.kusto")
.append("/")
.append("1.0.0-beta.4");
.append("1.0.0-beta.1");
if (!Configuration.getGlobalConfiguration().get("AZURE_TELEMETRY_DISABLED", false)) {
userAgentBuilder
.append(" (")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,15 @@

import com.azure.core.annotation.Fluent;
import com.azure.core.management.ProxyResource;
import com.azure.core.util.logging.ClientLogger;
import com.azure.resourcemanager.kusto.models.DefaultPrincipalsModificationKind;
import com.azure.resourcemanager.kusto.models.ProvisioningState;
import com.azure.resourcemanager.kusto.models.TableLevelSharingProperties;
import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonProperty;
import java.util.List;

/** Class representing an attached database configuration. */
@Fluent
public final class AttachedDatabaseConfigurationInner extends ProxyResource {
@JsonIgnore private final ClientLogger logger = new ClientLogger(AttachedDatabaseConfigurationInner.class);

/*
* Resource location.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,12 @@
import com.azure.resourcemanager.kusto.models.DefaultPrincipalsModificationKind;
import com.azure.resourcemanager.kusto.models.ProvisioningState;
import com.azure.resourcemanager.kusto.models.TableLevelSharingProperties;
import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonProperty;
import java.util.List;

/** Class representing the an attached database configuration properties of kind specific. */
@Fluent
public final class AttachedDatabaseConfigurationProperties {
@JsonIgnore private final ClientLogger logger = new ClientLogger(AttachedDatabaseConfigurationProperties.class);

/*
* The provisioned state of the resource.
*/
Expand Down Expand Up @@ -169,20 +166,20 @@ public AttachedDatabaseConfigurationProperties withTableLevelSharingProperties(
*/
public void validate() {
if (databaseName() == null) {
throw logger
throw LOGGER
.logExceptionAsError(
new IllegalArgumentException(
"Missing required property databaseName in model AttachedDatabaseConfigurationProperties"));
}
if (clusterResourceId() == null) {
throw logger
throw LOGGER
.logExceptionAsError(
new IllegalArgumentException(
"Missing required property clusterResourceId in model"
+ " AttachedDatabaseConfigurationProperties"));
}
if (defaultPrincipalsModificationKind() == null) {
throw logger
throw LOGGER
.logExceptionAsError(
new IllegalArgumentException(
"Missing required property defaultPrincipalsModificationKind in model"
Expand All @@ -192,4 +189,6 @@ public void validate() {
tableLevelSharingProperties().validate();
}
}

private static final ClientLogger LOGGER = new ClientLogger(AttachedDatabaseConfigurationProperties.class);
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,13 @@
package com.azure.resourcemanager.kusto.fluent.models;

import com.azure.core.annotation.Fluent;
import com.azure.core.util.logging.ClientLogger;
import com.azure.resourcemanager.kusto.models.AzureCapacity;
import com.azure.resourcemanager.kusto.models.AzureSku;
import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonProperty;

/** Azure resource SKU definition. */
@Fluent
public final class AzureResourceSkuInner {
@JsonIgnore private final ClientLogger logger = new ClientLogger(AzureResourceSkuInner.class);

/*
* Resource Namespace and Type.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,12 @@
package com.azure.resourcemanager.kusto.fluent.models;

import com.azure.core.annotation.Fluent;
import com.azure.core.util.logging.ClientLogger;
import com.azure.resourcemanager.kusto.models.Reason;
import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonProperty;

/** The result returned from a check name availability request. */
@Fluent
public final class CheckNameResultInner {
@JsonIgnore private final ClientLogger logger = new ClientLogger(CheckNameResultInner.class);

/*
* Specifies a Boolean value that indicates if the name is available.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,13 @@
import com.azure.resourcemanager.kusto.models.State;
import com.azure.resourcemanager.kusto.models.TrustedExternalTenant;
import com.azure.resourcemanager.kusto.models.VirtualNetworkConfiguration;
import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonProperty;
import java.util.List;
import java.util.Map;

/** Class representing a Kusto cluster. */
@Fluent
public final class ClusterInner extends Resource {
@JsonIgnore private final ClientLogger logger = new ClientLogger(ClusterInner.class);

/*
* The SKU of the cluster.
*/
Expand Down Expand Up @@ -638,7 +635,7 @@ public List<PrivateEndpointConnectionInner> privateEndpointConnections() {
*/
public void validate() {
if (sku() == null) {
throw logger
throw LOGGER
.logExceptionAsError(
new IllegalArgumentException("Missing required property sku in model ClusterInner"));
} else {
Expand All @@ -651,4 +648,6 @@ public void validate() {
innerProperties().validate();
}
}

private static final ClientLogger LOGGER = new ClientLogger(ClusterInner.class);
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,14 @@

import com.azure.core.annotation.Fluent;
import com.azure.core.management.ProxyResource;
import com.azure.core.util.logging.ClientLogger;
import com.azure.resourcemanager.kusto.models.ClusterPrincipalRole;
import com.azure.resourcemanager.kusto.models.PrincipalType;
import com.azure.resourcemanager.kusto.models.ProvisioningState;
import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonProperty;

/** Class representing a cluster principal assignment. */
@Fluent
public final class ClusterPrincipalAssignmentInner extends ProxyResource {
@JsonIgnore private final ClientLogger logger = new ClientLogger(ClusterPrincipalAssignmentInner.class);

/*
* The cluster principal.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,11 @@
import com.azure.resourcemanager.kusto.models.ClusterPrincipalRole;
import com.azure.resourcemanager.kusto.models.PrincipalType;
import com.azure.resourcemanager.kusto.models.ProvisioningState;
import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonProperty;

/** A class representing cluster principal property. */
@Fluent
public final class ClusterPrincipalProperties {
@JsonIgnore private final ClientLogger logger = new ClientLogger(ClusterPrincipalProperties.class);

/*
* The principal ID assigned to the cluster principal. It can be a user
* email, application ID, or security group name.
Expand Down Expand Up @@ -191,21 +188,23 @@ public String aadObjectId() {
*/
public void validate() {
if (principalId() == null) {
throw logger
throw LOGGER
.logExceptionAsError(
new IllegalArgumentException(
"Missing required property principalId in model ClusterPrincipalProperties"));
}
if (role() == null) {
throw logger
throw LOGGER
.logExceptionAsError(
new IllegalArgumentException("Missing required property role in model ClusterPrincipalProperties"));
}
if (principalType() == null) {
throw logger
throw LOGGER
.logExceptionAsError(
new IllegalArgumentException(
"Missing required property principalType in model ClusterPrincipalProperties"));
}
}

private static final ClientLogger LOGGER = new ClientLogger(ClusterPrincipalProperties.class);
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
package com.azure.resourcemanager.kusto.fluent.models;

import com.azure.core.annotation.Fluent;
import com.azure.core.util.logging.ClientLogger;
import com.azure.resourcemanager.kusto.models.AcceptedAudiences;
import com.azure.resourcemanager.kusto.models.ClusterNetworkAccessFlag;
import com.azure.resourcemanager.kusto.models.EngineType;
Expand All @@ -18,15 +17,12 @@
import com.azure.resourcemanager.kusto.models.State;
import com.azure.resourcemanager.kusto.models.TrustedExternalTenant;
import com.azure.resourcemanager.kusto.models.VirtualNetworkConfiguration;
import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonProperty;
import java.util.List;

/** Class representing the Kusto cluster properties. */
@Fluent
public final class ClusterProperties {
@JsonIgnore private final ClientLogger logger = new ClientLogger(ClusterProperties.class);

/*
* The state of the resource.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,9 @@

import com.azure.core.annotation.Fluent;
import com.azure.core.management.ProxyResource;
import com.azure.core.util.logging.ClientLogger;
import com.azure.resourcemanager.kusto.models.EventGridDataConnection;
import com.azure.resourcemanager.kusto.models.EventHubDataConnection;
import com.azure.resourcemanager.kusto.models.IotHubDataConnection;
import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.annotation.JsonSubTypes;
import com.fasterxml.jackson.annotation.JsonTypeInfo;
Expand All @@ -30,8 +28,6 @@
})
@Fluent
public class DataConnectionInner extends ProxyResource {
@JsonIgnore private final ClientLogger logger = new ClientLogger(DataConnectionInner.class);

/*
* Resource location.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,11 @@
package com.azure.resourcemanager.kusto.fluent.models;

import com.azure.core.annotation.Fluent;
import com.azure.core.util.logging.ClientLogger;
import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonProperty;

/** Class representing an data connection validation. */
@Fluent
public final class DataConnectionValidationInner {
@JsonIgnore private final ClientLogger logger = new ClientLogger(DataConnectionValidationInner.class);

/*
* The name of the data connection.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,13 @@
package com.azure.resourcemanager.kusto.fluent.models;

import com.azure.core.annotation.Fluent;
import com.azure.core.util.logging.ClientLogger;
import com.azure.resourcemanager.kusto.models.DataConnectionValidationResult;
import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonProperty;
import java.util.List;

/** The list Kusto data connection validation result. */
@Fluent
public final class DataConnectionValidationListResultInner {
@JsonIgnore private final ClientLogger logger = new ClientLogger(DataConnectionValidationListResultInner.class);

/*
* The list of Kusto data connection validation errors.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,8 @@

import com.azure.core.annotation.Fluent;
import com.azure.core.management.ProxyResource;
import com.azure.core.util.logging.ClientLogger;
import com.azure.resourcemanager.kusto.models.ReadOnlyFollowingDatabase;
import com.azure.resourcemanager.kusto.models.ReadWriteDatabase;
import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.annotation.JsonSubTypes;
import com.fasterxml.jackson.annotation.JsonTypeInfo;
Expand All @@ -28,8 +26,6 @@
})
@Fluent
public class DatabaseInner extends ProxyResource {
@JsonIgnore private final ClientLogger logger = new ClientLogger(DatabaseInner.class);

/*
* Resource location.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,14 @@

import com.azure.core.annotation.Fluent;
import com.azure.core.management.ProxyResource;
import com.azure.core.util.logging.ClientLogger;
import com.azure.resourcemanager.kusto.models.DatabasePrincipalRole;
import com.azure.resourcemanager.kusto.models.PrincipalType;
import com.azure.resourcemanager.kusto.models.ProvisioningState;
import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonProperty;

/** Class representing a database principal assignment. */
@Fluent
public final class DatabasePrincipalAssignmentInner extends ProxyResource {
@JsonIgnore private final ClientLogger logger = new ClientLogger(DatabasePrincipalAssignmentInner.class);

/*
* The database principal.
*/
Expand Down
Loading