forked from Azure/azure-sdk-for-java
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixes to Tables tests, as well as client documentation and exceptions. (
Azure#23336) * - Ensured that tests exclusive to Storage are not run when testing a Cosmos endpoint. - Fixed tests that failed due to Cosmos not returning a `[email protected]` property in a `TableEntity` alongside the `Timestamp` property, like Storage does. This is apparently intended behavior, so we now treat `Timestamp` as a special case that needs to be always converted to `OffsetDateTime`. - Fixed the `setGetProperty()` tests in `TableServiceClientTest` and `TableServiceAsyncClientTest`, which failed for Storage because properties can take up to 30 seconds to be propagated on Storage accounts. - Updated `TableEntity` documentation to remove all mentions of using its subclasses. - Updated clients to properly map the implementation `TableServiceErrorException` to the public `TableServiceException` in operations such as `getAccessPolicies()`, `getProperties()`, `setProperties()` and `getStatistics()`, including their "withResponse" variants. - Updated client documentation to accurately reflect which exceptions are thrown by service methods. - Fixed batch operations to properly log exceptions other than `TableTransactionFailedException`. * Removed unused import. * Applied PR feedback: - Removed assumption that prevented the `canUseSasTokenToCreateValidTableClient()` tests to run on Cosmos endpoints. - Changed `TableAsyncClient.submitTransactionWithResponse()` to wrap an `IllegalArgumentException` with a `Mono` when no transaction actions are provided. - Updated `submitTransactionAsyncWithSameRowKeys()` tests to check the error's status code instead of just the error message. * Skipping `canUseSasTokenToCreateValidTableClient()` tests for Cosmos endpoints to unblock nightly test runs. Will investigate further until this can be resolved. * Fixed CheckStyle issue.
- Loading branch information
Showing
12 changed files
with
341 additions
and
80 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.