avoid unwanted changes to arcAgentryConfigurations #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimbleby
requested review from
bavneetsingh16,
deeksha345 and
anagg929
as code owners
bavneetsingh16
approved these changes
Nov 15, 2024
dimbleby
deleted the
davidhotham/unwanted-arc-agentry-configurations-changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered by Paul in an upcoming E2E test enhancement: if we
then we make an unwanted change to
ArcAgentryConfigurations, pushing an empty value over the value that we had previously provided.If we're not changing the proxy settings, then don't update this part of the connected cluster resource.