Fix E2E tests persistent flakiness + build hanging #3188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SummarySummary
CoverageNo assemblies have been covered. |
SummarySummary
CoverageNo assemblies have been covered. |
SummarySummary
CoverageNo assemblies have been covered. |
SummarySummary
CoverageNo assemblies have been covered. |
SummarySummary
CoverageNo assemblies have been covered. |
jmprieur
approved these changes
Jan 9, 2025
jmprieur
reviewed
Jan 9, 2025
| @@ -265,6 +258,10 @@ public static void KillProcessTrees(Queue<Process> processQueue) | |||
| { | |||
| processQueue.Enqueue(child); | |||
| } | |||
| await currentProcess.WaitForExitAsync(); | |||
There was a problem hiding this comment.
do they exit by themselves?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 1: The persistent flakiness 🥐
After enabling output and error logs, we see this in a build with failing E2E tests.
We can't replicate this locally as we have the certs configured locally. Moving to HTTP from HTTPS should resolve this for our builds.
Issue 2: Build Hanging
Adding logging from the output/error streams on the processes mean that we need to close them. 🤦♀️ Interestingly, the IdWeb build didn't fail on this, but the Unified build did.