Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add null handling for process output/error data in UiTestHelpers #3184

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Add null handling for process output/error data in UiTestHelpers #3184

merged 2 commits into from
Jan 7, 2025

Conversation

kllysng
Copy link
Contributor

@kllysng kllysng commented Jan 7, 2025

No description provided.

@kllysng kllysng requested a review from a team as a code owner January 7, 2025 17:58
jmprieur
jmprieur approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I provided a suggestion to improve the readability of the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

Summary

Summary
Generated on: 1/7/2025 - 6:14:37 PM
Coverage date: 1/7/2025 - 6:13:17 PM - 1/7/2025 - 6:14:23 PM
Parser: MultiReport (2x Cobertura)
Assemblies: 0
Classes: 0
Files: 0
Line coverage:
Covered lines: 0
Uncovered lines: 0
Coverable lines: 0
Total lines: 0
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

No assemblies have been covered.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

Summary

Summary
Generated on: 1/7/2025 - 6:30:09 PM
Coverage date: 1/7/2025 - 6:28:50 PM - 1/7/2025 - 6:29:55 PM
Parser: MultiReport (2x Cobertura)
Assemblies: 0
Classes: 0
Files: 0
Line coverage:
Covered lines: 0
Uncovered lines: 0
Coverable lines: 0
Total lines: 0
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

No assemblies have been covered.

@kllysng kllysng merged commit 1710b64 into master Jan 7, 2025
5 checks passed
@kllysng kllysng deleted the kellysong/msg-output-fix branch January 7, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmprieur jmprieur jmprieur approved these changes

@keegan-caruso keegan-caruso keegan-caruso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kllysng @jmprieur @keegan-caruso