Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update values for build #2118

Merged
merged 14 commits into from
Mar 21, 2023
Merged

Update values for build #2118

merged 14 commits into from
Mar 21, 2023

Conversation

westin-m
Copy link
Contributor

No description provided.

@jennyf19
Copy link
Collaborator

This is looking great so far!

@jennyf19
Copy link
Collaborator

jennyf19 commented Mar 18, 2023 •
edited
Loading

@westin-m we need to update the email alias from [email protected] to [email protected] in the tsa.config file: notificationAlias: '[email protected]'

Thank you!

@westin-m westin-m marked this pull request as ready for review March 20, 2023 18:27
@jennyf19
Copy link
Collaborator 

codebase: NewOrUpdate

You'll need to delete from lines 12 to 26 and add in these lines after inputs:
GdnPublishTsaOnboard: false GdnPublishTsaConfigFile: '$(Build.SourcesDirectory)/build/tsaConfig.json'
so the new json file is picked up.

Refers to: build/template-publish-analysis-and-cleanup.yaml:13 in 329ae9d. [](commit_id = 329ae9d, deletion_comment = False)

@westin-m
Copy link
Contributor Author

You'll need to delete from lines 12 to 26 and add in these lines after inputs: GdnPublishTsaOnboard: false GdnPublishTsaConfigFile: '$(Build.SourcesDirectory)/build/tsaConfig.json' so the new json file is picked up.

Pushed these changes

jennyf19
jennyf19 approved these changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: let's just make sure to run a test build and ensure the warnings do go away

jmprieur
jmprieur approved these changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @westin-m

Did you run a release build to test these changes?

@westin-m
Copy link
Contributor Author

LGTM Thanks @westin-m

Did you run a release build to test these changes?

Doing that right now, had to fix a typo

jmprieur
jmprieur approved these changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @westin-m

@westin-m westin-m requested review from jennyf19 and jmprieur March 21, 2023 21:21
jmprieur
jmprieur approved these changes Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks @westin-m

@westin-m westin-m merged commit 5c38def into master Mar 21, 2023
@westin-m westin-m linked an issue Mar 21, 2023 that may be closed by this pull request
[Fundamentals] Update Roslyn analyzers, TSA upload, and binskim in the build #2114
Closed
@jennyf19
Copy link
Collaborator

#2137

@jennyf19 jennyf19 deleted the westinm/buildUpdates branch March 21, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmprieur jmprieur jmprieur approved these changes

@JoshLozensky JoshLozensky Awaiting requested review from JoshLozensky

@jennyf19 jennyf19 Awaiting requested review from jennyf19

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fundamentals] Update Roslyn analyzers, TSA upload, and binskim in the build
3 participants
@westin-m @jennyf19 @jmprieur