Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for response type in mergedoptions #1227

Merged
merged 2 commits into from
May 28, 2021
Merged

fix for response type in mergedoptions #1227

merged 2 commits into from
May 28, 2021

Conversation

jennyf19
Copy link
Collaborator

@jennyf19
Copy link
Collaborator Author

@jmprieur we need to do more here, fyi. i might wait to merge

jmprieur
jmprieur approved these changes May 28, 2021
View reviewed changes
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Let's do it only for ResponseType.

@jennyf19
Copy link
Collaborator Author

fixed.

In reply to: 671583673

jmprieur
jmprieur approved these changes May 28, 2021
View reviewed changes
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks @jennyf19

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jennyf19 jennyf19 merged commit 044e0b0 into master May 28, 2021
@jennyf19 jennyf19 deleted the jennyf/FixMergeOptions branch May 28, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmprieur jmprieur jmprieur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennyf19 @jmprieur