Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kasong/automation add retry #2504

Merged
merged 9 commits into from
Jan 27, 2025
Merged

Kasong/automation add retry #2504

merged 9 commits into from
Jan 27, 2025

Conversation

kaisong1990
Copy link
Contributor

Proposed changes

  1. Add 3 times retry back
  2. Lab team helped to fix the b2c account/password ieeus
  3. Add waiting time for a cookie prompt from OS

All tests passed now:

https://identitydivision.visualstudio.com/IDDP/_build/results?buildId=1419893&view=results

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

@kaisong1990 kaisong1990 requested review from a team as code owners January 27, 2025 16:53
@kaisong1990 kaisong1990 enabled auto-merge (squash) January 27, 2025 16:53
azure-pipelines[bot]
azure-pipelines bot reviewed Jan 27, 2025
View reviewed changes
MSAL/test/automation/tests/MSALBaseUITest.m
@@ -85,13 +85,20 @@ - (void)assertAccessTokenExpired
- (void)assertAuthUIAppearsUsingEmbeddedWebView:(BOOL)useEmbedded
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not update CHANGELOG.md.

Please consider if this change would be noticeable to a partner or user and either update CHANGELOG.md or resolve this conversation.

ameyapat
ameyapat reviewed Jan 27, 2025
View reviewed changes
azure_pipelines/templates/tests-with-conf-file.yml
condition: failed()
displayName: "Publish crash report if any"
inputs:
targetPath: "/Users/runner/Library/Logs/DiagnosticReports"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does such a folder exist in the pipeline? I think you'd need to create it, if it doesn't

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ameya, yes, it is there always (or maybe there is always certain system crash?). It is a macOS system owned folder to store crash logs from macOS

@kaisong1990 kaisong1990 merged commit b08278c into dev Jan 27, 2025
21 checks passed
@kaisong1990 kaisong1990 deleted the kasong/automation-add-retry branch January 27, 2025 17:56
kaisong1990 added a commit that referenced this pull request Feb 5, 2025
@kaisong1990 @antonioalwan
@antrix1989 @Veena11 @juan-arias @oldalton @Yuki-YuXin @spetrescu84 @mipetriu @nilo-ms
Release/1.7.0 (#2505)
e2562d3 
* Add automation token binding settings

* Update core.

* modified:   MSAL/IdentityCore

* merge release 1.6.2 back to dev

* Use older version of xcpretty

* Minor automation tweaks

* Fixed cookie clearing

* Update submodule

* Trigger build, due to pipeline error.

* Updated parentViewController documentation

* Update MSAL submodule

* Publish temporary Swift Package 2024-11-27 10:36:29

* Revert "Publish temporary Swift Package 2024-11-27 10:36:29"

This reverts commit d879d57.

* Test with newer Xcode & macOS version

* Test newer iOS version

* MSA automation support

* update submodule

* 1.1.10 & 1.1.12

* 2.1.11

* 1.1.13

* 1.1.2

* 1.1.5

* 2.1.10

* 2.1.10 move to the right place

* 2.1.5

* 2.1.6

* 2.1.7&2.1.8

* pass 2.1.11

* 1.1.10 pass

* 1.1.11 pass

* 1.1.12 pass

* 1.1.13 pass

* 1.1.2 pass

* 1.1.5 pass

* 2.1.10 pass + use correct error message

* 2.1.5 pass

* 2.1.6 pass

* 2.1.7 pass

* 2.1.8 pass

* remove correlation id one because it's out of scope

* Verify Custom URL Domain - Sign In

* add signInCustomDomain2InSuccess and skip

* tenant_id + replicate name

* submodule update (#2426)

* submodule update

* dummy change

---------

Co-authored-by: Kai Song <[email protected]>

* trigger pipeline

* wrong key

* Address comments

* Revert "Address comments"

This reverts commit 14531e1.

* Address comments

* Add new error mapping for http error code 403 and 404

* update the error name

* Revert "Address comments"

This reverts commit 9b56bc2.

* Revert "Revert "Address comments""

This reverts commit 4463c60.

* Use OTP instead of password to customURL

* Address comments

* Pass the local test

* Merge main in dev (#2448)

* merge Hotfix/1.6.3 in main (#2437)

* Add support of "lookup" mode in broker (#2414)

* Update core.

* modified:   MSAL/IdentityCore

* modified:   CHANGELOG.md

* modified:   MSAL/IdentityCore

* modified:   MSAL/IdentityCore

* modified:   MSAL/IdentityCore

* Update changelog.

* bump version.

* modified:   MSAL/IdentityCore

* Skipping failing E2E tests for macOS due to Keychain access required by the Kevault component

* Revert "Skipping failing E2E tests for macOS due to Keychain access required by the Kevault component"

This reverts commit d239b4c.

* Switch PR validation to proper macOS version

* Revert "Switch PR validation to proper macOS version"

This reverts commit 1c93d83.

* Move pipeline to run with Xcode 16 on MacOS 14 (#2456)

* submodule update

* more log

* upgrade to Xcode 16

* submodule update

* update native auth xcode version

* switch to arm

* disable pod related task in automation

* dummy try

* Revert back

* Add image info

* Spetrescu/test macos 14 (#2447)

* Revert macos to 14 and comment

* Proper spacing

* Spacing

* Spacing

* Using Xcode 16.1

* Change simulator to 18.1 for xcode 16.1

* Update simulator

* Correct macos version

---------

Co-authored-by: Silviu Petrescu <[email protected]>

* [iOS SDK] Skip E2E tests that don't work on macOS (#2450)

* Skipping e2e tests for macOS that don't work

* Fix macOS version for PR validation script

* Test skip reason updated (#2451)

---------

Co-authored-by: Kai Song <[email protected]>
Co-authored-by: Silviu Petrescu <[email protected]>
Co-authored-by: Silviu Petrescu <[email protected]>

* Uninstall xcpretty version 0.4.0 before installing version 0.3.0

* Add new errors for passkey biometric policy mismatch  and invalid passkey extension

* Update IdentityCore to use latest dev branch

* add broker submodule check yaml file and add yaml to pr-validation for testing

* remove extra quote symbol in yaml file

* fixed common core checkout script and added openssl changes from wpj submodule check

* add wpj openssl checkout changes

* remove testing changes to pr-validation

* update codeowners file (#2479)

* update to dev Common Core

* Add new PSSO error

* Add PSSO registration needs repair status in getDeviceInfo psso status

* Native Auth E2E test fix (#2480)

* throw XCTSkip("1secmail service is down. Ignoring test for now.")

* Remove one from the ignored batch

* retrigger checks

* update the skip comment

---------

Co-authored-by: Danilo Raspa <[email protected]>

* update common core for prompt suppress

* update submodule

* update submodule

* update submodule

* update common core to newest suppress PR

* update submodule

* update common core

* bring in newest dev + suppress code in common core

* Add parameters to public methods (#2492)

* add parametreized interface

* Unit test for parameters

* deprecated get access token

* UserAccountResult tests

* added tests for SignInAfter states

* Objective C/SAmple app public

* Update MSAL/src/native_auth/public/MSALNativeAuthPublicClientApplication.swift

Co-authored-by: Danilo Raspa <[email protected]>

* Update MSAL/src/native_auth/public/parameters/MSALNativeAuthGetAccessTokenParameters.swift

Co-authored-by: Danilo Raspa <[email protected]>

* Update MSAL/src/native_auth/public/parameters/MSALNativeAuthSignInAfterSignUpParameters.swift

Co-authored-by: Danilo Raspa <[email protected]>

* Update MSAL/src/native_auth/public/parameters/MSALNativeAuthSignInParameters.swift

Co-authored-by: Danilo Raspa <[email protected]>

* Update MSAL/src/native_auth/public/parameters/MSALNativeAuthSignUpParameters.swift

Co-authored-by: Danilo Raspa <[email protected]>

* Update MSAL/src/native_auth/public/parameters/MSALNativeAuthResetPasswordParameters.swift

Co-authored-by: Danilo Raspa <[email protected]>

* Update MSAL/src/native_auth/public/parameters/MSALNativeAuthSignInAfterResetPasswordParameters .swift

Co-authored-by: Danilo Raspa <[email protected]>

* Update MSAL/src/native_auth/public/parameters/MSALNativeAuthSignInParameters.swift

Co-authored-by: Danilo Raspa <[email protected]>

* Update MSAL/src/native_auth/public/MSALNativeAuthUserAccountResult.swift

Co-authored-by: Danilo Raspa <[email protected]>

* Update MSAL/src/native_auth/public/state_machine/state/SignInAfterResetPasswordState.swift

Co-authored-by: Danilo Raspa <[email protected]>

* PR Comments

* PR Changes

* Homogenized wording to flow

* Add default value for force refresh

* PR comments

* Update changelog

* Update changelog

* Updated version

* latest ic

---------

Co-authored-by: Danilo Raspa <[email protected]>

* update common core to dev

* Native auth: Add support for claims request (#2496)

* add parametreized interface

* Unit test for parameters

* deprecated get access token

* UserAccountResult tests

* added tests for SignInAfter states

* Objective C/SAmple app public

* Update MSAL/src/native_auth/public/MSALNativeAuthPublicClientApplication.swift

Co-authored-by: Danilo Raspa <[email protected]>

* Update MSAL/src/native_auth/public/parameters/MSALNativeAuthGetAccessTokenParameters.swift

Co-authored-by: Danilo Raspa <[email protected]>

* Update MSAL/src/native_auth/public/parameters/MSALNativeAuthSignInAfterSignUpParameters.swift

Co-authored-by: Danilo Raspa <[email protected]>

* Update MSAL/src/native_auth/public/parameters/MSALNativeAuthSignInParameters.swift

Co-authored-by: Danilo Raspa <[email protected]>

* Update MSAL/src/native_auth/public/parameters/MSALNativeAuthSignUpParameters.swift

Co-authored-by: Danilo Raspa <[email protected]>

* Update MSAL/src/native_auth/public/parameters/MSALNativeAuthResetPasswordParameters.swift

Co-authored-by: Danilo Raspa <[email protected]>

* Update MSAL/src/native_auth/public/parameters/MSALNativeAuthSignInAfterResetPasswordParameters .swift

Co-authored-by: Danilo Raspa <[email protected]>

* Update MSAL/src/native_auth/public/parameters/MSALNativeAuthSignInParameters.swift

Co-authored-by: Danilo Raspa <[email protected]>

* Update MSAL/src/native_auth/public/MSALNativeAuthUserAccountResult.swift

Co-authored-by: Danilo Raspa <[email protected]>

* Update MSAL/src/native_auth/public/state_machine/state/SignInAfterResetPasswordState.swift

Co-authored-by: Danilo Raspa <[email protected]>

* PR Comments

* PR Changes

* Homogenized wording to flow

* add claims request to the signIn parameters

* Add claims request field to signIn method

* fix compilation and add new unit tests, Fix integration test

* update changelog file

* fix indentation

---------

Co-authored-by: Silviu Petrescu <[email protected]>
Co-authored-by: Silviu Petrescu <[email protected]>

* Add new psso error

* Kasong/automation add retry (#2504)

* Add back retry on MSAL automation

* Fix typo

* Update typo

* quite MSAL automation logs

* Update ymal for retry

* publish crash logs if any

* publish crash logs if any

* trye to fix all failures

* Add sleep

---------

Co-authored-by: Kai Song <[email protected]>

* release 1.7.0

* Kasong/1.7.0 release patch (#2506)

* merge Hotfix/1.6.3 in main (#2437)

* Add support of "lookup" mode in broker (#2414)

* Update core.

* modified:   MSAL/IdentityCore

* modified:   CHANGELOG.md

* modified:   MSAL/IdentityCore

* modified:   MSAL/IdentityCore

* modified:   MSAL/IdentityCore

* Update changelog.

* bump version.

* Updating MSAL framework checksum & url for 1.6.3 [skip ci]

* Update common core

---------

Co-authored-by: Sergei Demchenko <[email protected]>
Co-authored-by: Kai Song <[email protected]>

* Kasong/update common core conflict (#2511)

* merge Hotfix/1.6.3 in main (#2437)

* Add support of "lookup" mode in broker (#2414)

* Update core.

* modified:   MSAL/IdentityCore

* modified:   CHANGELOG.md

* modified:   MSAL/IdentityCore

* modified:   MSAL/IdentityCore

* modified:   MSAL/IdentityCore

* Update changelog.

* bump version.

* Updating MSAL framework checksum & url for 1.6.3 [skip ci]

* Update release common to latest

---------

Co-authored-by: Sergei Demchenko <[email protected]>
Co-authored-by: Kai Song <[email protected]>

* Kasong/merge conflict 1.7.0 (#2512)

* merge Hotfix/1.6.3 in main (#2437)

* Add support of "lookup" mode in broker (#2414)

* Update core.

* modified:   MSAL/IdentityCore

* modified:   CHANGELOG.md

* modified:   MSAL/IdentityCore

* modified:   MSAL/IdentityCore

* modified:   MSAL/IdentityCore

* Update changelog.

* bump version.

* Updating MSAL framework checksum & url for 1.6.3 [skip ci]

---------

Co-authored-by: Sergei Demchenko <[email protected]>
Co-authored-by: Kai Song <[email protected]>

---------

Co-authored-by: Antonio Alwan <[email protected]>
Co-authored-by: Sergey Demchenko <[email protected]>
Co-authored-by: Veena Soman <[email protected]>
Co-authored-by: Juan Arias Roldan <[email protected]>
Co-authored-by: Olga Dalton <[email protected]>
Co-authored-by: Juan Arias <[email protected]>
Co-authored-by: Olga Dalton <[email protected]>
Co-authored-by: Yuki-YuXin <[email protected]>
Co-authored-by: Kai Song <[email protected]>
Co-authored-by: Silviu Petrescu <[email protected]>
Co-authored-by: Silviu Petrescu <[email protected]>
Co-authored-by: Yuki-YuXin <[email protected]>
Co-authored-by: mipetriu <[email protected]>
Co-authored-by: Danilo Raspa <[email protected]>
Co-authored-by: mipetriu <[email protected]>
Co-authored-by: Danilo Raspa <[email protected]>
Co-authored-by: Kai Song <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameyapat ameyapat ameyapat left review comments

@azure-pipelines azure-pipelines[bot] azure-pipelines[bot] left review comments

@mipetriu mipetriu mipetriu approved these changes

@jasoncoolmax jasoncoolmax Awaiting requested review from jasoncoolmax jasoncoolmax is a code owner automatically assigned from AzureAD/appleidentityteam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaisong1990 @ameyapat @mipetriu