Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update initialization.md #7495

Closed
wants to merge 1 commit into from
Closed

Conversation

Neutrino-Sunset
Copy link

Initialisation instructions are missing the fact that the MsalRedirectComponent needs to be instantiated.

Initialisation instructions are missing the fact that the MsalRedirectComponent needs to be instantiated.
@github-actions github-actions bot added documentation Related to documentation. msal-angular Related to @azure/msal-angular package labels Jan 8, 2025
@Neutrino-Sunset
Copy link
Author

@microsoft-github-policy-service agree

@jo-arroyo
Copy link
Collaborator

@Neutrino-Sunset As some Angular applications are now using standalone components, the MsalRedirectComponent does not need to used in all scenarios, see our redirect doc for more details.

Closing.

@jo-arroyo jo-arroyo closed this Jan 9, 2025
@Neutrino-Sunset
Copy link
Author

I'm sorry but that doesn't make sense.

Yes, when using standalone components redirects need to be handled differently.

However, the example in the initialization page is expliclty using module based initialization, and in that scenario not instantiating the MsalRedirectComponent results in a runtime error as the redirect fails. Test it yourself if you don't believe me. As such the initialization example is currently broken.

Additionally, the Redirects with standalone components documentation is also lacking. For example it states:

Depending on your application architecture, you may have to subscribe to handleRedirectObservable() in other areas as well.

So which applications architectures are affected? And what other areas require handleRedirectObservable? This is documentation which explains nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation. msal-angular Related to @azure/msal-angular package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants