Fix unhandled exception in NAA JS Runtime scenario #7475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codexeon
requested review from
sameerag,
tnorling,
hectormmg,
jo-arroyo,
peterzenz,
konstantin-msft,
lalimasharda and
shylasummers
as code owners
|
Reminder: This PR appears to be stale. If this PR is still a work in progress please mark as draft. |
microsoft-github-policy-service
bot
added
Needs: Attention 👋
peterzenz
approved these changes
Jan 10, 2025
codexeon
force-pushed
the
dasau/jsruntime_exception_fix
branch
from
fbdec53 to
c7b2955
Compare
| @@ -56,12 +54,6 @@ export function validateCryptoAvailable(): void { | |||
| if (!window.crypto) { | |||
| throw createBrowserAuthError(BrowserAuthErrorCodes.cryptoNonExistent); | |||
| } | |||
| if (!window.crypto.subtle) { | |||
There was a problem hiding this comment.
Not sure it we can safely remove this check as crypto.subtle is widely used in BrowserCrypto. cc @tnorling
tnorling
approved these changes
Jan 13, 2025
codexeon
force-pushed
the
dasau/jsruntime_exception_fix
branch
from
7a9678c to
b0af4d9
Compare
hectormmg
added a commit
that referenced
this pull request
Jan 14, 2025
To prevent regressions, add a test that simulates JS Runtime environment and tests E2E scenario for NAA. This will fail until #7475 is merged. --------- Co-authored-by: Hector Morales <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were regressions to the NAA JS Runtime scenario by the following commits, adding new platform API dependencies in the NAA critical path. This change is tested to get JS Runtime back into a working state.