Dynamically load BrowserPerformanceMeasurement to capture browser perf measurements if session storage flag is set
#6748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
msal-browser
konstantin-msft
force-pushed
the
reduce_telemetry_overhead
branch
from
6426d72 to
4d523b5
Compare
konstantin-msft
requested review from
sameerag,
tnorling,
hectormmg,
jo-arroyo,
peterzenz and
Robbie-Microsoft
as code owners
konstantin-msft
force-pushed
the
reduce_telemetry_overhead
branch
from
7caaead to
4d2c212
Compare
konstantin-msft
changed the title
BrowserPerformanceMeasurement in favor of calculating telemetry event duration in place with browser performance APIBrowserPerformanceMeasurement to capture browser perf measurements if session storage flag is set
tnorling
reviewed
Dec 12, 2023
tnorling
reviewed
Dec 12, 2023
tnorling
reviewed
Dec 12, 2023
tnorling
reviewed
Dec 12, 2023
tnorling
reviewed
Dec 12, 2023
tnorling
requested changes
Dec 12, 2023
konstantin-msft
force-pushed
the
reduce_telemetry_overhead
branch
2 times, most recently
from
b727943 to
884a55b
Compare
sameerag
approved these changes
Dec 14, 2023
tnorling
reviewed
Dec 14, 2023
| const inProgressEvent = super.startMeasurement( | ||
| measureName, | ||
| correlationId | ||
| ); | ||
| const startTime: number | undefined = supportsBrowserPerformanceNow() | ||
| ? window.performance.now() | ||
| : undefined; |
There was a problem hiding this comment.
What do we see in our telemetry if the performance API isn't available? Do we get some sort of indication or do we toss out the data?
There was a problem hiding this comment.
If performance API isn't available, then telemetry event duration is calculated using Unix epoch, a subject to clock skew, instead of browser.performance.now(). No data is tossed out. There is no indication of performance API availability in telemetry though.
tnorling
approved these changes
Dec 14, 2023
…elemetry event duration in place with browser performance API. - Calculate telemetry event duration using Unix epoch if browser performance API is not available.
…surements if session storage flag is enabled. - Update browser perf doc.
Co-authored-by: Thomas Norling <[email protected]>
- Move static functions out of BrowserPerformanceClient.ts.
konstantin-msft
force-pushed
the
reduce_telemetry_overhead
branch
from
e0a6bc4 to
b397807
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
BrowserPerformanceMeasurementto capture browser perf measurements if session storage flag is set.Background:
Browser performance measures introduce additional overhead caused by buffer polling and linear-ish time complexity when calling getEntriesByName(). We can directly use
window.performance.now()instead to measure telemetry event duration.