Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception is thrown in acquireTokenByClientCredential if tenantId is missing #5805

Merged
merged 17 commits into from
Apr 5, 2023
Merged

Exception is thrown in acquireTokenByClientCredential if tenantId is missing #5805

merged 17 commits into from
Apr 5, 2023

Conversation

Robbie-Microsoft
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added msal-common Related to msal-common package msal-node Related to msal-node package labels Mar 20, 2023
@Robbie-Microsoft Robbie-Microsoft marked this pull request as ready for review March 20, 2023 18:41
@Robbie-Microsoft Robbie-Microsoft linked an issue Mar 20, 2023 that may be closed by this pull request
Exception is thrown in acquireTokenByClientCredential if tenantId is missing #5567
Closed
bgavrilMS
bgavrilMS approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@bgavrilMS bgavrilMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is for the new major version ?

@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (msal-browser-v3@ae244e5). Click here to learn what that means.
The diff coverage is n/a.

Flag Coverage Δ *Carryforward flag
msal-angular 96.61% <0.00%> (?)
msal-browser 84.12% <0.00%> (?) Carriedforward from f32615d
msal-common 84.10% <0.00%> (?)
msal-node 78.46% <0.00%> (?)
msal-node-extensions 45.81% <0.00%> (?) Carriedforward from f32615d
msal-react 94.82% <0.00%> (?)
node-token-validation 86.68% <0.00%> (?)

*This pull request uses carry forward flags. Click here to find out more.

@Robbie-Microsoft Robbie-Microsoft merged commit 7f37a7c into msal-browser-v3 Apr 5, 2023
@Robbie-Microsoft Robbie-Microsoft deleted the acquireTokenByClientCredentialException-v3 branch April 5, 2023 19:33
@ghost
Copy link

ghost commented May 3, 2023

🎉@azure/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented May 3, 2023

🎉@azure/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@star-starry-sea star-starry-sea mentioned this pull request Jan 24, 2025
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgavrilMS bgavrilMS bgavrilMS approved these changes

@hectormmg hectormmg hectormmg left review comments

@sameerag sameerag sameerag approved these changes

@tnorling tnorling Awaiting requested review from tnorling tnorling is a code owner

@peterzenz peterzenz Awaiting requested review from peterzenz peterzenz is a code owner

@jennyf19 jennyf19 Awaiting requested review from jennyf19 jennyf19 is a code owner

@jmprieur jmprieur Awaiting requested review from jmprieur jmprieur is a code owner

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

@konstantin-msft konstantin-msft Awaiting requested review from konstantin-msft konstantin-msft is a code owner

@derisen derisen Awaiting requested review from derisen

Assignees
No one assigned
Labels
msal-common Related to msal-common package msal-node Related to msal-node package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception is thrown in acquireTokenByClientCredential if tenantId is missing
8 participants
@Robbie-Microsoft @codecov-commenter @hectormmg @bgavrilMS @derisen @sameerag @rgins16 @konstantin-msft