Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make redirect URI a required parameter for auth code flow #188

Merged
merged 2 commits into from
Mar 4, 2021
Merged

Make redirect URI a required parameter for auth code flow #188

merged 2 commits into from
Mar 4, 2021

Conversation

jhendrixMSFT
Copy link
Contributor

Don't hard-code the nativeclient redirect URI.
Make the auth code a parameter for the public client (the same was
already done for confidential client).

@jhendrixMSFT
Make redirect URI a required parameter for auth code flow
4b8d5d0 
Don't hard-code the nativeclient redirect URI.
Make the auth code a parameter for the public client (the same was
already done for confidential client).
@jhendrixMSFT jhendrixMSFT added the bug Something isn't working label Mar 4, 2021
@jhendrixMSFT
Copy link
Contributor Author

Change is based on the discussion here.

@jhendrixMSFT jhendrixMSFT mentioned this pull request Mar 4, 2021
Closed
abhidnya13
abhidnya13 approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@abhidnya13 abhidnya13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

I think we should also mention may be in the comments/reference docs that this RedirectUri has to be the same as the one used in the first leg of this flow.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 4, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jhendrixMSFT jhendrixMSFT merged commit e27db6e into dev Mar 4, 2021
@jhendrixMSFT jhendrixMSFT deleted the authcode_redirect branch March 4, 2021 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhidnya13 abhidnya13 abhidnya13 approved these changes

@sangonzal sangonzal Awaiting requested review from sangonzal

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhendrixMSFT @abhidnya13