Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for source link #750

Merged
merged 1 commit into from
Jan 3, 2019
Merged

Add support for source link #750

merged 1 commit into from
Jan 3, 2019

Conversation

bgavrilMS
Copy link
Member

This will allow developers to debug into MSAL, as long as they use VS 15.7+

It will do 2 things:

  1. Generate a snupkg package that contains the pdb files (one for each platform). We will need to upload this to NuGet
  2. Add a manifest containing urls to source files in the nuget package (You can use NuGet package explorer to see this manifest)

henrik-me
henrik-me approved these changes Jan 3, 2019
View reviewed changes
Copy link
Contributor

@henrik-me henrik-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bgavrilMS bgavrilMS merged commit 833eb5e into master Jan 3, 2019
@bgavrilMS bgavrilMS deleted the bogavril/sourcelink branch January 3, 2019 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrik-me henrik-me henrik-me approved these changes

@jennyf19 jennyf19 jennyf19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bgavrilMS @jennyf19 @henrik-me