-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add caller sdk id and version to telemetry server side and client side #4864
Conversation
src/client/Microsoft.Identity.Client/ApiConfig/Parameters/AcquireTokenCommonParameters.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/Extensibility/AcquireTokenParameterBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/Internal/Requests/RequestBase.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/TelemetryCore/Internal/Events/ApiEvent.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/Extensibility/AcquireTokenParameterBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/Internal/Requests/RequestBase.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Unit/AppConfigTests/ConfidentialClientApplicationBuilderTests.cs
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/AppConfig/ApplicationConfiguration.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/AppConfig/ApplicationConfiguration.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/Platforms/Features/OpenTelemetry/OtelInstrumentation.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/Platforms/Features/OpenTelemetry/OtelInstrumentation.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/TelemetryCore/Http/HttpTelemetryManager.cs
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/TelemetryCore/OpenTelemetry/IOtelInstrumentation.cs
Show resolved
Hide resolved
Thanks @neha-bhargava! Can you help me understand how these fields are meant to interact with the As we discussed, please be sure to update the schema here once this is finalized: https://eng.ms/docs/microsoft-security/identity/entra-developer-application-platform/id4s-identity-for-services/authn-middleware-sdk-microsoft-identity-service-essentials/microsoft-identity-service-essentials/articles/using-mise/telemetry-schema |
…lemetry/OtelInstrumentation.cs Co-authored-by: Tim Hannifin <[email protected]>
…lemetry/OtelInstrumentation.cs Co-authored-by: Tim Hannifin <[email protected]>
…iguration.cs Co-authored-by: Tim Hannifin <[email protected]>
…iguration.cs Co-authored-by: Tim Hannifin <[email protected]>
Since this value is to recognize the API used, this value can be added per request too. So, the supplemental-version-info could not be used in this case. Also we need to send this information to server side telemetry hence using this API. |
…D/microsoft-authentication-library-for-dotnet into nebharg/ztaSupportSdkInfo
src/client/Microsoft.Identity.Client/AppConfig/BaseAbstractApplicationBuilder.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/AppConfig/BaseAbstractApplicationBuilder.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/TelemetryCore/TelemetryConstants.cs
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Unit/TelemetryTests/HttpTelemetryTests.cs
Outdated
Show resolved
Hide resolved
…licationBuilder.cs Co-authored-by: Gladwin Johnson <[email protected]>
…licationBuilder.cs Co-authored-by: Gladwin Johnson <[email protected]>
Fixes #4863
Changes proposed in this request
Add caller sdk details to client side and server side telemetry
Testing
Unit and integration tests
Performance impact
Documentation