-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log MsalVersion to ITelemetryClient #3747
Log MsalVersion to ITelemetryClient #3747
Conversation
src/client/Microsoft.Identity.Client/TelemetryCore/TelemetryClient/MsalTelemetryEventDetails.cs
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/AppConfig/ConfidentialClientApplicationBuilder.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Unit/PublicApiTests/TelemetryClientTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main feedback is then to not send version with every request and only once as part of config_update event.
Missed to remove that earlier. Removed now. Thanks |
src/client/Microsoft.Identity.Client/AppConfig/ConfidentialClientApplicationBuilder.cs
Outdated
Show resolved
Hide resolved
Looking at the API "WithTelemetryClient", Line 322 in 86ffe42
|
The current API uses |
Fixes #3745
Changes proposed in this request
Log MSAL version
Testing
Performance impact
Documentation