Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log MsalVersion to ITelemetryClient #3747

Merged
merged 8 commits into from
Oct 28, 2022

Conversation

neha-bhargava
Copy link
Contributor

@neha-bhargava neha-bhargava commented Oct 12, 2022

Fixes #3745

Changes proposed in this request
Log MSAL version

Testing

Performance impact

Documentation

  • All relevant documentation is updated.

Copy link
Contributor

@pmaytak pmaytak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main feedback is then to not send version with every request and only once as part of config_update event.

@neha-bhargava
Copy link
Contributor Author

Main feedback is then to not send version with every request and only once as part of config_update event.

Missed to remove that earlier. Removed now. Thanks

@SameerK-MSFT
Copy link
Contributor

Looking at the API "WithTelemetryClient",

public ConfidentialClientApplicationBuilder WithTelemetryClient(params ITelemetryClient[] telemetryClients)
two thoughts.

  1. Since this can accept one or more ITelemetryClient objects, can this be renamed to plural version WithTelemetryClients.
  2. Since most developers will use a single Telemetry client, an override can be added that accept single client. This will keep API simple for the developers. This will be a breaking change. But if minimal customers are using it, it may be worth. Thoughts?

@pmaytak
Copy link
Contributor

pmaytak commented Oct 26, 2022

Looking at the API "WithTelemetryClient",

public ConfidentialClientApplicationBuilder WithTelemetryClient(params ITelemetryClient[] telemetryClients)

two thoughts.

  1. Since this can accept one or more ITelemetryClient objects, can this be renamed to plural version WithTelemetryClients.
  2. Since most developers will use a single Telemetry client, an override can be added that accept single client. This will keep API simple for the developers. This will be a breaking change. But if minimal customers are using it, it may be worth. Thoughts?

The current API uses params so it can already accept a single telemetry client.

@TimHannMSFT
Copy link
Contributor

        if (telemetryClients.Length > 0)

nit: this check isn't needed right? If it's length zero the foreach won't be entered.


Refers to: src/client/Microsoft.Identity.Client/AppConfig/ConfidentialClientApplicationBuilder.cs:333 in 839cb78. [](commit_id = 839cb78, deletion_comment = False)

@neha-bhargava neha-bhargava enabled auto-merge (squash) October 27, 2022 05:46
@neha-bhargava neha-bhargava merged commit c2edfdc into main Oct 28, 2022
@neha-bhargava neha-bhargava deleted the nebharg/LogMsalVersionToTelemetryPipeline branch October 28, 2022 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add MSAL version to TelemetryClient logging
6 participants