Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve some WAM error messages #3696

Merged
merged 5 commits into from
Sep 26, 2022
Merged

Improve some WAM error messages #3696

merged 5 commits into from
Sep 26, 2022

Conversation

bgavrilMS
Copy link
Member

Fixes #3675

Changes proposed in this request

  • improve error messages
  • fix "HasScopes" helper and use it
  • unit tests

Testing

Performance impact

Documentation

  • All relevant documentation is updated.

@bgavrilMS bgavrilMS enabled auto-merge (squash) September 26, 2022 12:48
@bgavrilMS bgavrilMS merged commit 9b68726 into main Sep 26, 2022
@bgavrilMS bgavrilMS deleted the bogavril/scopes branch September 26, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmaytak pmaytak pmaytak left review comments

@gladjohn gladjohn gladjohn approved these changes

@SameerK-MSFT SameerK-MSFT SameerK-MSFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Request] WAM support for no scopes
4 participants
@bgavrilMS @pmaytak @SameerK-MSFT @gladjohn