Identity cache logger updates #3404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
March 23, 2022 23:41
…ity with Xamarin mac/Uap
Refactoring
Clean Up
Clean Up
…gerUpdates # Conflicts: # src/client/Microsoft.Identity.Client/Instance/Region/RegionManager.cs # src/client/Microsoft.Identity.Client/Internal/Broker/NullBroker.cs # src/client/Microsoft.Identity.Client/Microsoft.Identity.Client.csproj # src/client/Microsoft.Identity.Client/Platforms/Android/Broker/AndroidAccountManagerBroker.cs # src/client/Microsoft.Identity.Client/Platforms/Android/Broker/AndroidContentProviderBroker.cs # src/client/Microsoft.Identity.Client/Platforms/netcore/NetCorePlatformProxy.cs # src/client/Microsoft.Identity.Client/TokenCache.ITokenCacheInternal.cs # src/client/Microsoft.Identity.Client/TokenCacheNotificationArgs.cs # src/client/Microsoft.Identity.Client/Utils/EnumerableExtensions.cs # tests/Microsoft.Identity.Test.Common/Core/Helpers/AppAccessorWithPartitionAsserts.cs # tests/Microsoft.Identity.Test.Unit/AuthorityAliasesTests.cs # tests/Microsoft.Identity.Test.Unit/CoreTests/HttpTests/HttpManagerTests.cs
Refactoring
This reverts commit 82491f8.
bgavrilMS
reviewed
Jul 19, 2022
src/client/Microsoft.Identity.Client/Internal/Logger/LoggerHelper.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jul 19, 2022
src/client/Microsoft.Identity.Client/Internal/Logger/MsalIdentityLogger.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jul 19, 2022
src/client/Microsoft.Identity.Client/Internal/Logger/MsalLegacyIdentityLogger.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jul 19, 2022
src/client/Microsoft.Identity.Client/Internal/Logger/MsalIdentityLogger.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jul 19, 2022
src/client/Microsoft.Identity.Client/Internal/Logger/ILoggerAdapter.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jul 19, 2022
tests/Microsoft.Identity.Test.Unit/PublicApiTests/LoggerTests.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
approved these changes
Jul 19, 2022
added 4 commits
July 19, 2022 16:24
pmaytak
approved these changes
Jul 22, 2022
src/client/Microsoft.Identity.Client/TokenCacheNotificationArgs.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed in this request
Exposes the Identity Logger to the cache serialization via the TokenCacheNotificationArgs
The exposed IdentityLogger is a wrapper around the original identity logger where we are able to format the logged messages with the relevant MSAL information.
Testing
Unit test
Performance impact