add b2c authority host to list #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennyf19
force-pushed
the
jennyf/withB2CAuthority
branch
from
7771727 to
8dbd0c9
Compare
jennyf19
force-pushed
the
jennyf/withB2CAuthority
branch
from
8dbd0c9 to
0b74398
Compare
henrik-me
reviewed
Mar 28, 2019
| /// <summary> | ||
| /// No Redirect URI. | ||
| /// </summary> | ||
| public const string B2CHostNotTrusted = "B2C_host_not_trusted"; |
There was a problem hiding this comment.
B2CHostNotTrusted [](start = 28, length = 17)
Probably a different PR... but I believe JM wanted these to be on the exceptions (in this case that would be on the clientexception), #Resolved
henrik-me
reviewed
Mar 28, 2019
| @@ -66,7 +66,7 @@ internal static class MsalTestConstants | |||
| public const string AuthorityWindowsNet = "https://" + ProductionPrefCacheEnvironment + "/" + Utid + "/"; | |||
| public const string B2CAuthority = "https://login.microsoftonline.in/tfp/tenant/policy/"; | |||
| public const string B2CLoginAuthority = "https://sometenantid.b2clogin.com/tfp/sometenantid/policy/"; | |||
| public const string B2CRandomHost = "https://sometenantid.randomhost.com/tfp/sometenantid/policy/"; | |||
| public const string B2CCustomDomain = "https://catsareamazing.com/tfp/catsareamazing/policy/"; | |||
There was a problem hiding this comment.
catsareamazing [](start = 55, length = 14)
:) #ByDesign
There was a problem hiding this comment.
|
@henrik-me build passed here |
bgavrilMS
reviewed
Apr 3, 2019
| return Task.FromResult(defaultEndpoint); | ||
| } | ||
|
|
||
| throw MsalExceptionFactory.GetClientException( |
There was a problem hiding this comment.
There is a test called B2CMicrosoftOnlineCreateAuthority that now consistently fails because of this. What suprises me is that it passed on the PR build or it was not run. Investigating...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@henrik-me have a few questions for you.