remove apiconfig and appconfig namespaces for public [1006] #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennyf19
approved these changes
Mar 26, 2019
henrik-me
reviewed
Mar 26, 2019
| @@ -37,7 +37,6 @@ | |||
| using System.Threading; | |||
| using Microsoft.Identity.Client.ApiConfig; | |||
There was a problem hiding this comment.
this ? Is there a way to remove the AppConfig namespace completely?
There was a problem hiding this comment.
AppConfig namespace is completely gone. ApiConfig has two child namespaces which I'd prefer to keep.
henrik-me
reviewed
Mar 26, 2019
| @@ -29,7 +29,7 @@ | |||
| using System.Threading; | |||
| using System.Threading.Tasks; | |||
| using Microsoft.Identity.Client; | |||
| using Microsoft.Identity.Client.ApiConfig; | |||
| using Microsoft.Identity.Client.ApiConfig.Executors; | |||
There was a problem hiding this comment.
ApiConfig [](start = 32, length = 9)
Do we still need this namespace?
There was a problem hiding this comment.
Yes, this Executors is internal code where we do the execution and i kept those namespaces around. the change here is i moved the interfaces down a folder so we can have appconfig and apiconfig root directories all be in microsoft.identity.client (since they're public)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1006