Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Call AcquireTokenInteractively instead of SignInInteractively #3437

Closed
gladjohn opened this issue Jun 30, 2022 · 2 comments · Fixed by #3456
Closed

[Bug] Call AcquireTokenInteractively instead of SignInInteractively #3437

gladjohn opened this issue Jun 30, 2022 · 2 comments · Fixed by #3456
Assignees
@gladjohn
Labels
Feature Request WAM
Milestone
4.46.0

Comments

@gladjohn
Copy link
Contributor

Tracking item to investigate and test all scenarios before doing the switch from SignInInteractively -> AcquireTokenInteractively

If you knew the account is in WAM and am able to rehydrate the account, please do call AcquireTokenInteractively instead of SignInInteractively. We don’t want to show any unnecessary prompt to the user.

Background :

When the account is not the default OS Account or when no login_hint is passed then we call the SIgnInInteractivelyAsync API, Now you get prompted to let windows remember the account for further sign-ins. Choosing to remember. WAM goes through this registration process.

Expected : With that message “Windows will remember the account”, I’d expect the UI is not shown when I pass the login_hint for subsequent calls. But instead the UI is always thrown requesting to enter password.

Suggested Fix : Call AcquireTokenInteractively instead of SignInInteractively
@gladjohn gladjohn added this to the 4.46.0 milestone Jun 30, 2022
@gladjohn gladjohn self-assigned this Jun 30, 2022
@bgavrilMS
Copy link
Member

This is more likely a bug and not a feature request, as I believe the legacy WAM has this functionality.

@gladjohn gladjohn changed the title [Feature Request] Call AcquireTokenInteractively instead of SignInInteractively [Bug] Call AcquireTokenInteractively instead of SignInInteractively Jul 5, 2022
gladjohn pushed a commit that referenced this issue Jul 6, 2022
@GladwinJohnson
Call AcquireTokenInteractively instead of SignInInteractively #3437
d1272d8
@gladjohn gladjohn mentioned this issue Jul 6, 2022
Merged
gladjohn pushed a commit that referenced this issue Jul 7, 2022
@GladwinJohnson
Call AcquireTokenInteractively instead of SignInInteractively #3437
50cab7c
gladjohn added a commit that referenced this issue Jul 11, 2022
@gladjohn @GladwinJohnson
Call AcquireTokenInteractively instead of SignInInteractively (#3456)
4eba04c 
* Call AcquireTokenInteractively instead of SignInInteractively #3437

* based on pr comments

* pr comments

* Call AcquireTokenInteractively instead of SignInInteractively #3437

* based on pr comments

* pr comments

* merge update and handling readAccountResult

* removed logging

* adding tests

* fix test error

* test update

* updated test

* message update

Co-authored-by: Gladwin Johnson <[email protected]>
@pmaytak
Copy link
Contributor

pmaytak commented Aug 4, 2022

Released in 4.46.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gladjohn gladjohn

Labels
Feature Request WAM
Projects
MSAL Customer Trust / QM
Archived in project
Milestone
4.46.0
3 participants
@bgavrilMS @pmaytak @gladjohn