Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging in users from multiple clouds fails #1048

Closed
1 task done
bgavrilMS opened this issue Apr 8, 2019 · 1 comment
Closed
1 task done

Logging in users from multiple clouds fails #1048

bgavrilMS opened this issue Apr 8, 2019 · 1 comment
Assignees
@bgavrilMS
Labels
bug
Milestone
3.0.3

Comments

@bgavrilMS
Copy link
Member

Which Version of MSAL are you using ?
MSAL 3.0.2-preview

Platform

What authentication flow has the issue?

  • Desktop / Mobile
    • Interactive

Repro

  1. Interactive Login with a German clould user in the German cloud
  2. Interactive Login with a Public cloud user in the public cloud, using the same client id

Expected: login should work
Actual: Public cloud user is not found

Root cause:

  • we perform instance discovery and cache the result for all clouds
  • in fact, we don't even need to perform intance discovery in order to figure out the OpenId discovery endpoint - the endpoint is constructed by appending /.well-known/openid-configuration to the authority url (according to the OpenID spec, (section 4)[https://openid.net/specs/openid-connect-discovery-1_0.html])
@bgavrilMS bgavrilMS self-assigned this Apr 8, 2019
@bgavrilMS bgavrilMS added the bug label Apr 8, 2019
@bgavrilMS bgavrilMS added this to the 3.0.3 milestone Apr 8, 2019
bgavrilMS added a commit that referenced this issue Apr 8, 2019
@bgavrilMS
Fix instance discovery for multi-cloud #1048
ede49a1
@bgavrilMS bgavrilMS mentioned this issue Apr 8, 2019
Merged
bgavrilMS added a commit that referenced this issue Apr 8, 2019
@bgavrilMS
Fix instance discovery for multi-cloud https://github.com/AzureAD/mic… (
01c977b 
#1049)

* Fix instance discovery for multi-cloud #1048

* Add more pre-validated hosts
@bgavrilMS bgavrilMS added the Fixed label Apr 8, 2019
@jennyf19
Copy link
Collaborator

jennyf19 commented Apr 8, 2019

included in msal 3.0.3-preview

@jennyf19 jennyf19 closed this as completed Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bgavrilMS bgavrilMS

Labels
bug
Projects
None yet
Milestone
3.0.3
Development

No branches or pull requests
2 participants
@bgavrilMS @jennyf19