Fix obsolete XML comments (#1074)

* Fix obsolete XML comments

* Improving the XML comments in MsalError to make them more actionable.

* Addressing PR feedback

* fix typo

src/Microsoft.Identity.Client/AuthenticationResult.cs

@@ -149,7 +149,7 @@ internal AuthenticationResult(MsalAccessTokenCacheItem msalAccessTokenCacheItem,
         /// <summary>
         /// Gets the account information. Some elements in <see cref="IAccount"/> might be null if not returned by the
         /// service. The account can be passed back in some API overloads to identify which account should be used such 
-        /// as <see cref="IClientApplicationBase.AcquireTokenSilentAsync(IEnumerable{string}, IAccount)"/> or
+        /// as <see cref="IClientApplicationBase.AcquireTokenSilent(IEnumerable{string}, IAccount)"/> or
         /// <see cref="IClientApplicationBase.RemoveAsync(IAccount)"/> for instance
         /// </summary>
         public IAccount Account { get; }
@@ -183,4 +183,4 @@ public string CreateAuthorizationHeader()
             return Oauth2AuthorizationHeader + AccessToken;
         }
     }
-}
+}

src/Microsoft.Identity.Client/ClientApplicationBase.cs

@@ -76,7 +76,7 @@ public abstract partial class ClientApplicationBase : IClientApplicationBase
         /// <Summary>
         /// User token cache. This case holds id tokens, access tokens and refresh tokens for accounts. It's used
         /// and updated silently if needed when calling <see cref="AcquireTokenSilent(IEnumerable{string}, IAccount)"/>
-        /// or one of the overrides of <see cref="AcquireTokenSilentAsync(IEnumerable{string}, IAccount)"/>.
+        /// or one of the overrides of <see cref="AcquireTokenSilent(IEnumerable{string}, IAccount)"/>.
         /// It is updated by each AcquireTokenXXX method, with the exception of <c>AcquireTokenForClient</c> which only uses the application
         /// cache (see <c>IConfidentialClientApplication</c>).
         /// </Summary>

src/Microsoft.Identity.Client/ConfidentialClientApplication.cs

@@ -74,7 +74,7 @@ internal ConfidentialClientApplication(ApplicationConfiguration configuration)
         /// It's usually used in Web Apps (for instance ASP.NET / ASP.NET Core Web apps) which sign-in users,
         /// and can request an authorization code.
         /// This method does not lookup the token cache, but stores the result in it, so it can be looked up
-        /// using other methods such as <see cref="IClientApplicationBase.AcquireTokenSilentAsync(IEnumerable{string}, IAccount)"/>.
+        /// using other methods such as <see cref="IClientApplicationBase.AcquireTokenSilent(IEnumerable{string}, IAccount)"/>.
         /// </summary>
         /// <param name="scopes">Scopes requested to access a protected API</param>
         /// <param name="authorizationCode">The authorization code received from the service authorization endpoint.</param>
@@ -174,8 +174,7 @@ AcquireTokenByRefreshTokenParameterBuilder IByRefreshToken.AcquireTokenByRefresh
 
         /// <Summary>
         /// Application token cache. This case holds access tokens and refresh tokens for the application. It's maintained 
-        /// and updated silently if needed when <see cref="AcquireTokenForClient(IEnumerable{string})"/> or one
-        /// of the overrides of <see cref="AcquireTokenForClientAsync(IEnumerable{string})"/>
+        /// and updated silently if needed when <see cref="AcquireTokenForClient(IEnumerable{string})"/>
         /// </Summary>
         /// <remarks>On .NET Framework and .NET Core you can also customize the token cache serialization.
         /// See https://aka.ms/msal-net-token-cache-serialization. This is taken care of by MSAL.NET on other platforms

src/Microsoft.Identity.Client/DeviceCodeResult.cs

@@ -39,7 +39,7 @@ namespace Microsoft.Identity.Client
     /// to be entered on that device.
     /// See https://aka.ms/msal-device-code-flow.
     /// </summary>
-    /// <seealso cref="PublicClientApplication.AcquireTokenWithDeviceCodeAsync(IEnumerable{string}, Func{DeviceCodeResult, System.Threading.Tasks.Task})"> and
+    /// <seealso cref="PublicClientApplication.AcquireTokenWithDeviceCode(IEnumerable{string}, Func{DeviceCodeResult, System.Threading.Tasks.Task})"> and
     /// the other overrides
     /// </seealso>
     public class DeviceCodeResult

src/Microsoft.Identity.Client/IAccount.cs

@@ -32,7 +32,7 @@ namespace Microsoft.Identity.Client
     /// The IAccount interface represents information about a single account. 
     /// The same user can be present in different tenants, that is, a user can have multiple accounts.
     /// An <c>IAccount</c> is returned in the <see cref="AuthenticationResult"/>.<see cref="AuthenticationResult.Account"/> property, and can be used as parameters
-    /// of PublicClientApplication and ConfidentialClientApplication methods acquiring tokens such as <see cref="ClientApplicationBase.AcquireTokenSilentAsync(System.Collections.Generic.IEnumerable{string}, IAccount)"/>
+    /// of PublicClientApplication and ConfidentialClientApplication methods acquiring tokens such as <see cref="ClientApplicationBase.AcquireTokenSilent(System.Collections.Generic.IEnumerable{string}, IAccount)"/>
     /// </summary>
     public interface IAccount
     {
@@ -56,4 +56,4 @@ public interface IAccount
         /// <remarks>Can be null, for example if this account was migrated to MSAL.NET from ADAL.NET v3's token cache</remarks>
         AccountId HomeAccountId { get; }
    }
-}
+}

src/Microsoft.Identity.Client/IByRefreshToken.cs

@@ -41,7 +41,7 @@ public partial interface IByRefreshToken
     {
         /// <summary>
         /// Acquires an access token from an existing refresh token and stores it and the refresh token into 
-        /// the user token cache, where it will be available for further AcquireTokenSilentAsync calls.
+        /// the user token cache, where it will be available for further AcquireTokenSilent calls.
         /// This method can be used in migration to MSAL from ADAL v2 and in various integration 
         /// scenarios where you have a RefreshToken available. 
         /// (see https://aka.ms/msal-net-migration-adal2-msal2)

src/Microsoft.Identity.Client/IClientApplicationBase.cs

@@ -45,7 +45,6 @@ public partial interface IClientApplicationBase
         /// <Summary>
         /// User token cache. This case holds id tokens, access tokens and refresh tokens for accounts. It's used 
         /// and updated silently if needed when calling <see cref="AcquireTokenSilent(IEnumerable{string}, IAccount)"/>
-        /// or one of the overrides of <see cref="AcquireTokenSilentAsync(IEnumerable{string}, IAccount)"/>.
         /// It is updated by each AcquireTokenXXX method, with the exception of <c>AcquireTokenForClient</c> which only uses the application
         /// cache (see <c>IConfidentialClientApplication</c>).
         /// </Summary>

src/Microsoft.Identity.Client/IConfidentialClientApplication.cs

@@ -41,8 +41,7 @@ public partial interface IConfidentialClientApplication : IClientApplicationBase
     {
         /// <Summary>
         /// Application token cache. This case holds access tokens and refresh tokens for the application. It's maintained 
-        /// and updated silently if needed when <see cref="AcquireTokenForClient(IEnumerable{string})"/> or one
-        /// of the overrides of <see cref="AcquireTokenForClientAsync(IEnumerable{string})"/>
+        /// and updated silently if needed when <see cref="AcquireTokenForClient(IEnumerable{string})"/>
         /// </Summary>
         /// <remarks>On .NET Framework and .NET Core you can also customize the token cache serialization.
         /// See https://aka.ms/msal-net-token-cache-serialization. This is taken care of by MSAL.NET on other platforms
@@ -56,7 +55,7 @@ public partial interface IConfidentialClientApplication : IClientApplicationBase
         /// It's usually used in Web Apps (for instance ASP.NET / ASP.NET Core Web apps) which sign-in users,
         /// and can request an authorization code.
         /// This method does not lookup the token cache, but stores the result in it, so it can be looked up
-        /// using other methods such as <see cref="IClientApplicationBase.AcquireTokenSilentAsync(IEnumerable{string}, IAccount)"/>.
+        /// using other methods such as <see cref="IClientApplicationBase.AcquireTokenSilent(IEnumerable{string}, IAccount)"/>.
         /// </summary>
         /// <param name="scopes">Scopes requested to access a protected API</param>
         /// <param name="authorizationCode">The authorization code received from the service authorization endpoint.</param>