Add new error mapping for http error code 403 and 404 #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![azure-pipelines[bot]](https://avatars.githubusercontent.com/in/9426?s=60&v=4){kind=small}
| @@ -171,6 +171,8 @@ typedef NS_ENUM(NSInteger, MSIDErrorCode) | |||
| */ | |||
There was a problem hiding this comment.
This pull request does not update changelog.txt.
Please consider if this change would be noticeable to a partner or user and either update changelog.txt or resolve this conversation.
juan-arias
reviewed
Dec 18, 2024
IdentityCore/src/MSIDError.h
Outdated
| @@ -171,6 +171,8 @@ typedef NS_ENUM(NSInteger, MSIDErrorCode) | |||
| */ | |||
|
|
|||
| MSIDErrorServerUnhandledResponse = -51500, | |||
| // http status Code 403 or 404 | |||
| MSIDErrorUnExpectedHttpResponse = -51501, | |||
There was a problem hiding this comment.
nit: typo unexpected
Suggested change
| MSIDErrorUnExpectedHttpResponse = -51501, | |
| MSIDErrorUnexpectedHttpResponse = -51501, |
| httpUnderlyingError = MSIDCreateError(MSIDHttpErrorCodeDomain, MSIDErrorUnExpectedHttpResponse, errorDescription, nil, nil, nil, context.correlationId, nil, YES); | ||
| } | ||
|
|
||
| NSError *httpError = MSIDCreateError(MSIDHttpErrorCodeDomain, MSIDErrorServerUnhandledResponse, errorDescription, nil, nil, httpUnderlyingError, context.correlationId, additionalInfo, YES); |
There was a problem hiding this comment.
Question, should the errorCode remain as MSIDErrorServerUnhandledResponse, since the MSIDErrorUnexpectedHttpResponse is now added as underlying error code?
There was a problem hiding this comment.
I didnt change it because we want to keep the top level error same.
There was a problem hiding this comment.
Oh yeah, you are right, I got confused.
juan-arias
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When token request fails with http error code 403 and 404 , we currently return MSIDErrorServerUnHandledResponse. This PR will add a new error MSIDErrorUnexpectedHttpResponse in case of http error code 403 or 404 and add this as an underlying error in the MSIDErrorServerUnHandledResponse error returned.
Type of change
Risk
Additional information