-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set proper lower bound for portalocker
dependency, drop packaging
dependency
#125
Conversation
@microsoft-github-policy-service agree |
There is a history behind it.
We started with
You can chime in in that PR and ping the reviewer there. That PR was developed based on a need at that time, but the integration test effort was suspended, so, there is little motivation to move forward. |
@rayluo Thanks for the feedback. My angle to this is trying to prune extra dependencies that aren't really needed – seems a waste to depend on (and download!) all of If, AIUI, not upgrading Portalocker is mostly the issue of more work for downstream Linux packagers, I understand and we'll need to deal accordingly, packagers can be an ornery bunch 😄
(I don't quite know how to check for the other major distros.) Maybe the heuristic for whether the
|
3fbffdb
to
9d7636e
Compare
@rayluo Okay, rebased + pushed a version that changes the pin to |
packaging
was only used as a dependency to check for the version ofportalocker
in use.This drops that dependency and instead corrects the minimum version of
portalocker
to the one checked here.It should be safe to depend on a version of
portalocker
that has been out for 3 years at this point, and is not quite as intrusive as #117 that would removeportalocker
altogether (and in all honesty, that PR has been out there for a year, with no sign of merging).