Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VerifySigning script #1305

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Fix VerifySigning script #1305

merged 1 commit into from
Dec 17, 2019

Conversation

GeoK
Copy link
Member

@GeoK GeoK commented Dec 17, 2019

  • The script now tries to find sn.exe files and signtool.exe in defined paths first. If any of the files is not found, the script will fallback to its previous behavior (recursively searching for sn.exe and signtool.exe in C:\Program Files(x86)).
  • Fixed authenticode signature verification.

@GeoK
Fix VerifySigning script
90ebd81 
* The script tries to find sn.exe files and signtool.exe in given
directories first. If any of the files is not present, the script will
fallback to its previous behavior (recursively searching for sn.exe and
signtool.exe in C:\Program Files(x86))
@GeoK GeoK requested a review from brentschmaltz December 17, 2019 01:33
brentschmaltz
brentschmaltz approved these changes Dec 17, 2019
View reviewed changes
Copy link
Member

@brentschmaltz brentschmaltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big improvement.

@GeoK GeoK merged commit fe28a00 into dev Dec 17, 2019
GeoK added a commit that referenced this pull request Dec 17, 2019
@GeoK
Fix VerifySigning script (#1305)
54eb297 
* The script tries to find sn.exe files and signtool.exe in given
directories first. If any of the files is not present, the script will
fallback to its previous behavior (recursively searching for sn.exe and
signtool.exe in C:\Program Files(x86))
@GeoK GeoK deleted the geok/fixVerifyScript branch December 26, 2019 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentschmaltz brentschmaltz brentschmaltz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeoK @brentschmaltz