Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance deployment error in case of 403 #305

Merged
merged 2 commits into from
Mar 31, 2023

Conversation

kumaraksh1
Copy link
Collaborator

Currently, a general error is shown , does not matter the reason of deployment failure.

@kumaraksh1 kumaraksh1 temporarily deployed to automation test March 29, 2023 13:20 — with GitHub Actions Inactive
@kumaraksh1 kumaraksh1 temporarily deployed to automation test March 29, 2023 13:20 — with GitHub Actions Inactive
@kumaraksh1 kumaraksh1 requested review from shpraka and removed request for kaverma, BALAGA-GAYATRI and kanika1894 March 30, 2023 09:56
@@ -54,7 +54,14 @@ function main() {
}
catch (error) {
isDeploymentSuccess = false;
core.setFailed("Deployment Failed with Error: " + error);
if (error.statusCode == 403) {
core.setFailed("The deployment to your web app failed with HTTP status code 403. \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tulikac can you please take a look the error message here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am merging this PR for now but wont release until @tulikac's confirmation.

@kumaraksh1 kumaraksh1 temporarily deployed to automation test March 31, 2023 13:02 — with GitHub Actions Inactive
@kumaraksh1 kumaraksh1 temporarily deployed to automation test March 31, 2023 13:02 — with GitHub Actions Inactive
@kumaraksh1 kumaraksh1 merged commit 7d2c9e2 into master Mar 31, 2023
kumaraksh1 added a commit that referenced this pull request Apr 6, 2023
* Enhance deployment error in case of 403

* Update aka.ms link

---------

Co-authored-by: Akshay Kumar <[email protected]>
@shpraka shpraka mentioned this pull request Apr 6, 2023
kumaraksh1 added a commit that referenced this pull request Apr 6, 2023
* Trim commit message (#301)

Co-authored-by: Akshay Kumar <[email protected]>

* Container Registry changed (#299)

* Update pr_check_windows_container_pubprofile.yml

* Moved the entries to secrets

* Update pr_check_windows_container_pubprofile.yml

* Update pr_check_windows_container_pubprofile.yml

* update azure-actions-appservice-rest version (#295)

* Added node modules and package-lock

* Update pr_check_windows_container_pubprofile.yml

* Update pr_check_windows_container_pubprofile.yml

* Update pr_check_windows_container_pubprofile.yml

* Update pr_check_windows_container_pubprofile.yml

* Update pr_check_windows_container_pubprofile.yml

* Update PR gate workflow file

* Enhance deployment error in case of 403 (#305)

* Enhance deployment error in case of 403

* Update aka.ms link

---------

Co-authored-by: Akshay Kumar <[email protected]>

* Release V2.2.7

* Adding lib folder

---------

Co-authored-by: kumaraksh1 <[email protected]>
Co-authored-by: Akshay Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants